g_skipcutscenes not working in SP

[GoogleCodeExporter]

g_skipcutscenes does not seem to have any impact on Single player games.  I 
think I have tracked down the issue:

bg_public.h defines gametypes as follows:

typedef enum {

        GT_COOP_SPEEDRUN,
        // other coop variations should come before this one, because we will
        // use g_gametype.integer <= GT_COOP
        GT_COOP,
        //-- coop games come before this --
        GT_SINGLE_PLAYER,
        //-- team games go after this --

        GT_MAX_GAME_TYPE
} gametype_t;

Making GT_SINGLE_PLAYER = 2 (if I still remember my C)

then in g_cmds.c:

        if (g_gametype.integer <= GT_COOP && g_skipcutscenes.integer)
                AICast_ScriptEvent( AICast_GetCastState( ent->s.number ), "trigger", "cameraInterrupt" );

Since GT_SINGLE_PLAYER will never be <= GT_COOP the cvar will never do anything 
for SP games.

Original issue reported on code.google.com by richard....@gmail.com on 25 Feb 2012 at 2:57

[GoogleCodeExporter]

Ah yes this was intended :)
Because I thought if you play the single player game, you want the full 
experience :D

But last week I discovered that I unintentionally removed some code where you 
can skip the cutscene if you press escape, so I'll restore that code

Original comment by frederik...@gmail.com on 25 Feb 2012 at 5:35

[GoogleCodeExporter]

True..  for the first 2-3 times, the full experience is good.  However, I've 
been stuck on the level boss1 (Where Helga uses the dagger to open the seal and 
gets transformed into a huge monster).   After killing everything I cant get to 
the dagger because the door Helga opened is closed and I cant progress.   
However that level starts with a rather long cut scene and it's quite boring 
after the first few times ;)

Is there any chance the SP game has been broken so that some levels can not be 
finished?

Original comment by richard....@gmail.com on 26 Feb 2012 at 1:07

[GoogleCodeExporter]

thats a good point you make, I'll enable it for the single player too.

Yes its possible that we broke the single player game, I'll ask marvin if he 
can take a look at that map, thank you for reporting !

Original comment by frederik...@gmail.com on 26 Feb 2012 at 4:45

[GoogleCodeExporter]

btw: on what system are you playing the game, and is it stable (does it crash 
sometimes ?)

Original comment by frederik...@gmail.com on 26 Feb 2012 at 4:56

[GoogleCodeExporter]

I'm playing on 64bit Fedora 16.   Pretty stable but I can crash it in SP if I 
want.
All I have to do is open the ingame UI (esc) during a cutscene and just leave 
it open.  A few seconds later the game will die.

Original comment by richard....@gmail.com on 26 Feb 2012 at 5:07

[GoogleCodeExporter]

I reverted this for now, because some cutscenes still started playing in single 
player

Original comment by frederik...@gmail.com on 23 Apr 2012 at 7:09

[GoogleCodeExporter]

Original comment by frederik...@gmail.com on 20 Mar 2013 at 10:01

• Changed state: WontFix