search

google-code-export / camlistore

Automatically exported from code.google.com/p/camlistore
Apache License 2.0
0 stars 0 forks source link

Switch to new oauth2 library #489

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Apparently the community is moving from the goauth2 package to:

https://github.com/golang/oauth2

We should switch, assuming all users of our current goauth2 continue to work 
with the new code.

The current code has bugs:

https://code.google.com/p/goauth2/issues/detail?id=31
https://code.google.com/p/goauth2/issues/detail?id=32
https://code.google.com/p/goauth2/issues/detail?id=33
... and no mutex protecting the token state in RefreshToken called by RoundTrip 
(which must be threadsafe)

Original issue reported on code.google.com by bradfitz on 10 Aug 2014 at 6:18

GoogleCodeExporter commented 9 years ago 
http://camlistore.org/r/3426

Original comment by mathieu....@gmail.com on 11 Aug 2014 at 9:22

GoogleCodeExporter commented 9 years ago 
Thanks. BTW, I filed some bugs against the new oauth2 library: 
https://github.com/golang/oauth2/issues

So we'll probably have to update several times here, but that's okay.

Original comment by bradfitz on 12 Aug 2014 at 3:28

GoogleCodeExporter commented 9 years ago 
current status: adg said new lib is not ready yet, so we're postponing the 
switch.

Original comment by mathieu....@gmail.com on 25 Aug 2014 at 3:09

GoogleCodeExporter commented 9 years ago 
This issue has moved to https://camlistore.org/issue/489

Original comment by bradfitz on 14 Dec 2014 at 11:37