search

google-code-export / camlistore

Automatically exported from code.google.com/p/camlistore
Apache License 2.0
0 stars 0 forks source link

Make left/right in detail views work again #508

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
When I rewrote the UI recently, we lost the ability to page through images by 
pressing the left right keys. It would be nice to get that back.

There are a lot of interesting bits to this:

- We need to pass an additional querystring param that is the query you're 
navigating through. I'm not sure if we should have a separate querystring param 
for the case of navigating through the children of a permanode, or whether we 
should express that as a query. In general I like to avoid special cases, so if 
there is no downside to expressing that as query, I'd prefer it.

- We need to load additional data periodically (and in the case of an external 
navigation, immediately)

- We used to make the piggy march backwards when you navigate left ... would be 
nice to bring this back

Original issue reported on code.google.com by zbo...@gmail.com on 29 Aug 2014 at 8:19

GoogleCodeExporter commented 9 years ago 
This is important for the 0.9 release, since it's a notable regression.

Lindsey, Aaron, either of you have time for this soon?

Original comment by bradfitz on 21 Oct 2014 at 3:07

GoogleCodeExporter commented 9 years ago 
I'll get it done in the next couple days

Original comment by els...@gmail.com on 21 Oct 2014 at 3:32

GoogleCodeExporter commented 9 years ago

Original comment by zbo...@gmail.com on 25 Oct 2014 at 1:48

GoogleCodeExporter commented 9 years ago 
Brad, if you could implement server-side support for returning a page of 
results "around" a particular item, it would make this feature a lot more 
robust and elegant client-side.

What I want to be able to say is:

var query = {
  sort: "-created",
  expression: "is:landscape",
  containing: "<ref>",
  limit: 51,
};

This would return a page with at most 25 results before <ref> in the sort and 
at most 25 results after <ref>. If <ref> does not match the query at all, then 
an empty set or error is returned.

===

I can implement a variation of what I did last time, but it was pretty hacky, 
and probably leads to UI bugs one way or other.

Original comment by zbo...@gmail.com on 25 Oct 2014 at 1:55

GoogleCodeExporter commented 9 years ago 
I could probably do that.

Original comment by bradfitz on 26 Oct 2014 at 12:53

GoogleCodeExporter commented 9 years ago 
This issue has moved to https://camlistore.org/issue/508

Original comment by bradfitz on 14 Dec 2014 at 11:37