google-code-export / camlistore

Automatically exported from code.google.com/p/camlistore
Apache License 2.0
0 stars 0 forks source link

support sharing search queries #512

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The share handler should support sharing search queries.

Proposal from discussion with Aaron:

- document current "share" claim schema
- augment share claim schema to instead of "target" have a "searchTarget" or 
some key whose value is a *search.SearchQuery JSON (with an expression or 
constraint)
- normal share handler auth applies
- if you fetch /share/sha1-hashofsearchquery you see the raw share claim
- if you add ?mode=search you get the search results
- when you fetch transitive resources (if transitive is true), you use the 
top-level search in your 'via' path
- we probably want a ?mode=describe too. maybe that's controlled by transitive. 
or the search that's shared gets to set the describe rules that are allowed

Original issue reported on code.google.com by bradfitz on 4 Sep 2014 at 7:35

GoogleCodeExporter commented 9 years ago
I see. I'll come back to https://camlistore-review.googlesource.com/3579 when 
we've advanced on this front then.

Original comment by mathieu....@gmail.com on 4 Sep 2014 at 9:31

GoogleCodeExporter commented 9 years ago

Original comment by mathieu....@gmail.com on 4 Sep 2014 at 9:31

GoogleCodeExporter commented 9 years ago
ISTM that your change and this change can proceed in parallel. What's blocking 
you about this?

Original comment by zbo...@gmail.com on 4 Sep 2014 at 10:47

GoogleCodeExporter commented 9 years ago
it's not so much being blocked as waiting to see how this turns out to 
reevaluate the approach I took. At first glance it seems some of the work I did 
(having the share handler perform describe queries and return the results) is 
common to what this proposal will help achieve.
So I figured maybe what I did can be simplified once this is completed, but I 
haven't thought about it much yet.

Original comment by mathieu....@gmail.com on 4 Sep 2014 at 10:57

GoogleCodeExporter commented 9 years ago
Ah, describe. Makes sense.

Original comment by zbo...@gmail.com on 4 Sep 2014 at 11:16

GoogleCodeExporter commented 9 years ago
https://camlistore-review.googlesource.com/3836 for mode=search support

Original comment by mathieu....@gmail.com on 1 Oct 2014 at 8:45

GoogleCodeExporter commented 9 years ago
Very related: (perhaps they should be merged into this one);

Issue 21
Issue 159

Original comment by bradfitz on 21 Oct 2014 at 10:51

GoogleCodeExporter commented 9 years ago
This issue has moved to https://camlistore.org/issue/512

Original comment by bradfitz on 14 Dec 2014 at 11:37