google-code-export / camlistore

Automatically exported from code.google.com/p/camlistore
Apache License 2.0
0 stars 0 forks source link

ui: feature flags #516

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Make it possible to enable conditional UI features via the config file.

This is regarding Mario Russo's email to the list:

Currently it is disabled by default - to use you must set a flag in index.js 
(line ~52):

cam.IndexPage = React.createClass({
    displayName: 'IndexPage',

    // TODO: flag to hide tagging functionality until development complete
    DEBUG_TAGS: false,  // set to true if you want to enable 

Please let me know if you notice any bugs.

Original issue reported on code.google.com by bradfitz on 23 Sep 2014 at 6:41

GoogleCodeExporter commented 9 years ago
Aaron says: "It seems like it should be easy to plumb a flag through to the 
discovery json, but I didn't want to add that distraction to Mario's change."

Original comment by bradfitz on 23 Sep 2014 at 6:41

GoogleCodeExporter commented 9 years ago
Am I understanding the request correctly?

- add a config key to server-config.json for UI features: ('uiFeatures'?)
- value for key should be available to the browser client in the 
CAMLISTORE_CONFIG object
- tag controls (and other ui config) can be driven by this

Original comment by mail...@gmail.com on 23 Sep 2014 at 8:01

GoogleCodeExporter commented 9 years ago
https://camlistore-review.googlesource.com/#/c/3806/

Original comment by mail...@gmail.com on 24 Sep 2014 at 9:06

GoogleCodeExporter commented 9 years ago
This issue has moved to https://camlistore.org/issue/516

Original comment by bradfitz on 14 Dec 2014 at 11:37