search

google-code-export / camlistore

Automatically exported from code.google.com/p/camlistore
Apache License 2.0
0 stars 0 forks source link

camget shouldn't skip files with wrong size #526

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
camget skips fetching files if they exist at all, rather than verifying they 
have the right size at least:

2014/10/19 18:58:48 Fetching sha1-0b329c474a9e39099cd9f8f8b262d5e72ae17931
2014/10/19 18:58:48 Skipping pics/IMG_20141014_193510.jpg; already exists.

^^^^

Note that it's 0 bytes, though:

mac:camlistore.org bradfitz$ ls -l  pics/IMG_20141014_193510.jpg
-rw-r--r--  1 bradfitz  eng  0 Oct 19 18:55 pics/IMG_20141014_193510.jpg

Original issue reported on code.google.com by bradfitz on 19 Oct 2014 at 4:59

GoogleCodeExporter commented 9 years ago

Original comment by bradfitz on 21 Oct 2014 at 3:11

GoogleCodeExporter commented 9 years ago 
ok that bug was fun. there was an actual bug due to a typo, but it was only 
triggered in verbose mode, because there was another bug related to the verbose 
condition.

https://camlistore-review.googlesource.com/4018

Original comment by mathieu....@gmail.com on 3 Nov 2014 at 10:05

GoogleCodeExporter commented 9 years ago 
TODO before closing that issue:

Add a test (probably integration?):

1) test that a camput file (with verbose) followed by a camget works: that it 
actually makes it to the server.

2) that a subsequent camput file -v does print the "already exists on server" 
message.

Original comment by mathieu....@gmail.com on 10 Nov 2014 at 6:17

GoogleCodeExporter commented 9 years ago 
43e0b72ec49ac9a0eac60392a68b11eef095374f

Original comment by mathieu....@gmail.com on 10 Nov 2014 at 6:18

GoogleCodeExporter commented 9 years ago 
https://camlistore-review.googlesource.com/4087

Original comment by mathieu....@gmail.com on 10 Nov 2014 at 10:48

GoogleCodeExporter commented 9 years ago 
Hmm, now I'm confused. since we were on 
https://camlistore-review.googlesource.com/4018 when you mentioned the 
additional test, I thought we were talking about camget, which is why I made 
https://camlistore-review.googlesource.com/4087
But now I see that you said "camput file -v". Is that what you actually meant?

Original comment by mathieu....@gmail.com on 10 Nov 2014 at 11:10

GoogleCodeExporter commented 9 years ago 
disregarding comment #3; and opened issue 547 instead.

Original comment by mathieu....@gmail.com on 12 Nov 2014 at 7:29

GoogleCodeExporter commented 9 years ago 
dabca278beb3513a60e6005722ecdaa07d8a42a4

Original comment by mathieu....@gmail.com on 12 Nov 2014 at 7:30

GoogleCodeExporter commented 9 years ago 
This issue has moved to https://camlistore.org/issue/526

Original comment by bradfitz on 14 Dec 2014 at 11:37