Minor bug in pkg/schema/dirreader.go

[GoogleCodeExporter]

If one creates a directory with a malformed entry the log line does not give 
the reason why said directory could not be read.
Patch attached.

Original issue reported on code.google.com by alessand...@gmail.com on 18 Nov 2014 at 2:00

Attachments:

• dirreader.patch

[GoogleCodeExporter]

We don't use patches on the bug tracker.

See http://camlistore.org/code for our code review and contribution process.

Original comment by bradfitz on 22 Nov 2014 at 11:48

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Do I really have to go through that for a trivial 4 bytes change?

Original comment by alessand...@gmail.com on 24 Nov 2014 at 9:12

[GoogleCodeExporter]

If we make an exception for you then surely others will ask for the same later, 
which would result in more arguing and time wasted.

And signing the CLA is unavoidable for legal reasons if you want to be on the 
AUTHORS list anyway.

Original comment by mathieu....@gmail.com on 24 Nov 2014 at 5:08

[GoogleCodeExporter]

Plus:

-- there is no code review here, so we force you to a site with good code 
review instead.

-- once you get used to submitting 4 byte changes, what about 5 byte? what 
about 6? where do one draw the line?

-- small patches are commonly just as dangerous as large ones.

If you submit the CLA, though, we could at least look at the change and take it 
over if you don't want to follow through.

Original comment by bradfitz on 24 Nov 2014 at 5:28

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

https://camlistore-review.googlesource.com/4157

Original comment by alessand...@gmail.com on 24 Nov 2014 at 5:51

[GoogleCodeExporter]

Original comment by bradfitz on 24 Nov 2014 at 6:45

• Changed state: Fixed

[GoogleCodeExporter]

This issue has moved to https://camlistore.org/issue/548

Original comment by bradfitz on 14 Dec 2014 at 11:38

• Added labels: IssueMoved, Restrict-AddIssueComment-Commit