google-code-export / cpassman

Automatically exported from code.google.com/p/cpassman
0 stars 0 forks source link

IE8 Password Entry List Improperly Formatted #237

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. IE8 with TeamPass 2.1 (latest as of 1/9:  
nilsteampassnet-TeamPass-ab8bc2c.zip)

2. Create three test entries.

3. First is hidden, subsequent are visible but not lined up correctly.

What is the expected output? What do you see instead?

 I expect to see the test entries listed in a row correctly.

What version of the product are you using?

 TeamPass 2.1

On what operating system? With what Browser (IEx, FFx, ...)

 Windows XP SP3
 IE8
 Server-side: httpd-2.2.15-5.el6.centos.x86_64

Please provide any additional information below.

 Works great on Chrome and Firefox (multiple versions).  Unfortunately, two of my users must use IE at work.

 Have attached screenshot of what I'm seeing.

Original issue reported on code.google.com by amar...@gmail.com on 10 Jan 2012 at 3:35

Attachments:

GoogleCodeExporter commented 9 years ago
Oops. Added screen-capture attachment that shows an entry highlighted.

Original comment by amar...@gmail.com on 10 Jan 2012 at 3:37

Attachments:

GoogleCodeExporter commented 9 years ago
Rah damn IE!

I'll do my best to improve that.

Thanks

Nils

Original comment by nils.cpa...@gmail.com on 10 Jan 2012 at 5:40

GoogleCodeExporter commented 9 years ago
I don't mind being a guinea pig if there's a beta version of a patch you'd like 
me to try on my end, by the way.

Original comment by amar...@gmail.com on 19 Jan 2012 at 7:11

GoogleCodeExporter commented 9 years ago
I've corrected that ... 
This is done in next 2.1.4 version.

Open file /sources/items.queries.php, and follow next steps:

$html .= '<span style="float:right;margin:2px 10px 0px 0px;">';
                         // display quick icon shortcuts ?
@@ -1455,6 +1503,7 @@ if ( isset($_POST['type']) ){
                        }else {
                            $html .= '<img src="includes/images/mini_star_disable.png"" onclick="ActionOnQuickIcon('.$reccord['id'].',1)" />';
                        }
+                       $html .= '</span>';

                        //mini icon for collab
                        if (isset($_SESSION['settings']['anyone_can_modify']) && $_SESSION['settings']['anyone_can_modify'] == 1) {
@@ -1466,7 +1515,7 @@ if ( isset($_POST['type']) ){
                            $html .= '</span>'.$item_collab.'</span>';
                        }

-                       $html .= '</li>';
+                       $html .= '</span></li>';

I've tested, it's ok.

Nils

Original comment by nils.cpa...@gmail.com on 24 Jan 2012 at 8:40

GoogleCodeExporter commented 9 years ago
This looks good on my end on IE (also tested Firefox). Thanks for the patch!

Original comment by amar...@gmail.com on 31 Jan 2012 at 6:16

GoogleCodeExporter commented 9 years ago
Good

Original comment by nils.cpa...@gmail.com on 3 Feb 2012 at 8:26