global vars in javascript scripts

google-code-export / django-grappelli

Automatically exported from code.google.com/p/django-grappelli

0 stars 0 forks source link

global vars in javascript scripts #24

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Inline.js is creating a lot of global variables, I presume inadvertently. 
This may not be producing any bugs right now but could later, and could
certainly interfere with other code.

I can submit a patch if that would help.

Original issue reported on code.google.com by jsmull...@gmail.com on 12 Mar 2009 at 3:19

GoogleCodeExporter commented 9 years ago

any improvement (especially when it comes to handling inlines) is more than 
welcome.

Original comment by sehmaschine on 12 Mar 2009 at 3:38

GoogleCodeExporter commented 9 years ago

attached is a patch that prevents the creation of unnecessary globals in 
Inline.js. 
It shouldn't behave any differently that the original except for not polluting 
the
global namespace.

Original comment by jsmull...@gmail.com on 12 Mar 2009 at 5:12

Attachments:

grappelli-globals-Inline.js.diff

GoogleCodeExporter commented 9 years ago

thanks.

Original comment by sehmaschine on 12 Mar 2009 at 6:31

Changed state: Fixed