search

google-code-export / django-grappelli

Automatically exported from code.google.com/p/django-grappelli
0 stars 0 forks source link

a few inconsistant styling issues #82

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Attachment 1)
  This is a filter_horizontal field in a TabularInline admin model.  For
some reason it doesn't display correctly.

Attachment 2)
  The DateTimeField here doesn't display correctly.  Though it does if it
is the first field on a line.  I would prefer the date/time to be on the
same line, though if this is not wanted it would be better if they lined up
vertically.

Cheers,
  Gontro

Original issue reported on code.google.com by Gontro@gmail.com on 16 Aug 2009 at 10:28

Attachments:

GoogleCodeExporter commented 9 years ago 
Also note that collapsing of inlines seems to be totally non-functional.  Don't 
know
what's happened here as I'm sure it worked in previous revisions.

Note:
  Running Grappelli 2 on Django 1.1 with Firefox 3.5.2

Original comment by Gontro@gmail.com on 16 Aug 2009 at 10:30

GoogleCodeExporter commented 9 years ago 
Aghh.. forgot to mention I'm running rev 389 of Grappelli 2

Original comment by Gontro@gmail.com on 16 Aug 2009 at 10:31

GoogleCodeExporter commented 9 years ago 
thanks ... will check that.

Original comment by sehmaschine on 16 Aug 2009 at 10:38

GoogleCodeExporter commented 9 years ago 
Another thing I noticed was the input field for an ImageField (probably a 
FileField
also) looks .. off.  I don't know if this is because I'm running my grappelli 
through
a mac browser (mac version of firefox), or if the styling is incomplete.  I've
enclosed a screengrab of the item in question.

Original comment by Gontro@gmail.com on 16 Aug 2009 at 10:50

Attachments:

GoogleCodeExporter commented 9 years ago 
we´re also on a mac. what do you mean with "... off"?

I´m on firefox 3.0 and here is a screenshot of my filefields-setup.

Original comment by sehmaschine on 16 Aug 2009 at 10:59

Attachments:

GoogleCodeExporter commented 9 years ago 
inline-collapsing should work again. it´s been a minor issue with the order of
loading javascripts.

Original comment by sehmaschine on 16 Aug 2009 at 11:24

GoogleCodeExporter commented 9 years ago 
The file field has a border that is different from the file field's in the 
image you
just posted.  Notice the black highlighting on the top and left..

Original comment by Gontro@gmail.com on 16 Aug 2009 at 11:32

Attachments:

GoogleCodeExporter commented 9 years ago 
Verified that inline-collapsing works again.  Now running Grappelli2 rev391

Original comment by Gontro@gmail.com on 16 Aug 2009 at 11:36

GoogleCodeExporter commented 9 years ago 
This isn't necessarily an issue but is it possible to put the 'save_on_top' 
buttons
horizontally inline with the title on the change form?  Attached an image to 
show how
it looks currently.. IMO it would look cleaner if the title and the 
'save_on_top'
buttons were on the same line.

Original comment by Gontro@gmail.com on 16 Aug 2009 at 12:08

Attachments:

GoogleCodeExporter commented 9 years ago 
Oh.. seems like the latest updates broke collapsing functionality for fieldsets
within stacked-inlines.

I have a stacked-inline called 'Links'. This inline has a fieldset within it 
called
'Meta Information' that is 'collapse-closed' .. 'Meta Information' now won't 
open.

Original comment by Gontro@gmail.com on 16 Aug 2009 at 12:15

GoogleCodeExporter commented 9 years ago 
are you sure? it works fine for me ...

Original comment by sehmaschine on 16 Aug 2009 at 12:21

GoogleCodeExporter commented 9 years ago 
Yeah positive.. I even checked that I updated all grappelli files and still 
nada..
I've enclosed an image of one of the sections that won't work.  its the
'collapse-closed' 'Meta Information' fieldset.

Original comment by Gontro@gmail.com on 16 Aug 2009 at 12:30

Attachments:

GoogleCodeExporter commented 9 years ago 
now I see. a fieldset within an inline.

this is truly a bug and I´ll open a different ticket for this one. that said, I
strongly discourage from setting things up that way - IMHO, that´s one level 
too much
(but of course it´s your setup and we´ll check that issue).

Original comment by sehmaschine on 16 Aug 2009 at 12:35

GoogleCodeExporter commented 9 years ago 
Thanks, I understand its not the best way to go about things.. though I prefer 
to
hide information that isn't often used, especially when I will have alot of 
inline
entries.

On another note (and this is probably me just being picky here) the onhover for 
a
collapsable fieldset within an inline seems a few pixels larger than the what it
looks like by default.. resulting in the fieldset seeming to 'move' onhover.  
Like I
said.. probably just me being picky because its just a small inconsistancy.

Original comment by Gontro@gmail.com on 16 Aug 2009 at 12:51

GoogleCodeExporter commented 9 years ago 
being picky is good ... I think that Grappelli is all about being picky in the 
first
place.

Original comment by sehmaschine on 16 Aug 2009 at 12:53

GoogleCodeExporter commented 9 years ago 
we´re going throught this step by step.

the image-field first: unfortunately, it´s currently not possible to style an
input[type="file"]. nothing we can do about that.

Original comment by sehmaschine on 17 Aug 2009 at 1:18

GoogleCodeExporter commented 9 years ago 
next one ... the save-on-top-issue: that´s not possible. first because you 
could have
a "delete"-button on the left-hand-side. second, there can already be buttons 
on the
headline-level (e.g. by other third-party-apps or within a change-form). 
therefore, a
wontfix for this one.

Original comment by sehmaschine on 17 Aug 2009 at 1:21

GoogleCodeExporter commented 9 years ago 
fieldset within inline not collapsible ... has already a seperate ticket and 
will be
solved.

Original comment by sehmaschine on 17 Aug 2009 at 1:22

GoogleCodeExporter commented 9 years ago 
datetime-field: solved with rev398.

Original comment by sehmaschine on 17 Aug 2009 at 2:05

GoogleCodeExporter commented 9 years ago 
collapsible fieldset within an inline: I´ll create a seperate ticket for this 
one
since it´s a bit more complicated.

Original comment by sehmaschine on 17 Aug 2009 at 2:14

GoogleCodeExporter commented 9 years ago 
m2m: resolved with rev399.

Original comment by sehmaschine on 17 Aug 2009 at 2:34

GoogleCodeExporter commented 9 years ago 
ok. guess we have worked out almost everything. if you still encounter problems,
please open a new ticket - because this one is already complicated to read.

Original comment by sehmaschine on 17 Aug 2009 at 2:35