google-code-export / django-hotclub

Automatically exported from code.google.com/p/django-hotclub
MIT License
0 stars 0 forks source link

lifestream.views imports SECRET_KEY but never uses it #70

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Removing superfluous import.

For some reason, this actually prevented me from getting Pinax running in my 
environment.

Original issue reported on code.google.com by sgt.hu...@gmail.com on 19 Sep 2008 at 7:41

Attachments:

GoogleCodeExporter commented 9 years ago
This was the fix to that problem earlier? While I think it is fine to prune 
extraneous imports I am afraid this isn't 
the correct fix to that problem. Oh well. Maybe there will be a more definitive 
answer to it later on.

Original comment by bros...@gmail.com on 19 Sep 2008 at 10:00

GoogleCodeExporter commented 9 years ago
It does seem to have fixed things. Even if you did want to use it, isn't the 
preferred method:

    from django.conf import settings
    do_something(settings.SECRET_KEY)

Original comment by sgt.hu...@gmail.com on 21 Sep 2008 at 3:43

GoogleCodeExporter commented 9 years ago
the lifestream app is going to be removed for 0.5

Original comment by leidel on 18 Oct 2008 at 9:33

GoogleCodeExporter commented 9 years ago
For the record, I did fix this, so if we ever bring back this app it should be 
okay.

Original comment by bros...@gmail.com on 18 Oct 2008 at 3:49