search

google-code-export / django-hotclub

Automatically exported from code.google.com/p/django-hotclub
MIT License
0 stars 0 forks source link

Error when confirming e-mail address in basic project #93

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Note - this is using the *basic* pinax project. It may (and from the look
of the error raised, will) work on the complete project.

What steps will reproduce the problem?
1. As a user, add an email address but don't verify it yet.
2. Log in to admin, go to emailconfirmation > emailaddresses
3. Find the email address you just entered, check "Verified" box, and save.

It should work fine and just save it, instead an OperationalError is
raised. See the attached file for the traceback and OS info.

The error seems to have been raised due to a dependency on the 'friends'
app from within the emailconfirmation app; in the basic project, the latter
is installed but not the former, causing an error when trying to verify an
email address. Note, this is when it is done through the admin, but the
process *should* (by that I mean it would be best practices) be the same
either way.

Original issue reported on code.google.com by crack...@gmail.com on 21 Oct 2008 at 6:28

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by jtau...@gmail.com on 21 Oct 2008 at 6:46

GoogleCodeExporter commented 9 years ago 
The culprit is account/forms.py line 17:

    from friends.models import JoinInvitation

this import causes friends to register for new user signal

Original comment by jtau...@gmail.com on 21 Oct 2008 at 8:54

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
this import is done because of the whole notion of a join invitation containing 
a
confirmation key which gets passed in to signup form

Original comment by jtau...@gmail.com on 21 Oct 2008 at 9:07

GoogleCodeExporter commented 9 years ago 
my current thinking is to move join invitation model to account.

friends could still provide the form for sending a JoinInvitation but the model
itself could live in account

that way other apps could send join invitations as well, and they could come 
from
site admins, not just your friends

this fits nicely with the private beta functionality we have planned

Original comment by jtau...@gmail.com on 21 Oct 2008 at 9:14

GoogleCodeExporter commented 9 years ago 
Fixed on 0.5.X branch in 1151 and on trunk in 1153

Original comment by jtau...@gmail.com on 23 Oct 2008 at 8:48