google-code-export / django-mptt

Automatically exported from code.google.com/p/django-mptt
Other
0 stars 0 forks source link

Python version support #75

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In the INSTALL is mentioned that mptt supports Python version 2.3 or higher.
However I've found lines with syntax supported from 2.5. E.g. mptt/managers.py 
+230

Could you update the INSTALL file to reflect the Python version, so that it 
doesn't cause confusion ;)

thx.

Jeffrey Gelens

Original issue reported on code.google.com by jgel...@gmail.com on 28 Sep 2010 at 10:07

GoogleCodeExporter commented 9 years ago
Hi Jeffrey

Thanks for the bug report.

Can you clarify that line number? 
[http://github.com/django-mptt/django-mptt/blob/master/mptt/managers.py#L230 
managers.py:230] looks okay to me.

Original comment by craig.ds@gmail.com on 28 Sep 2010 at 11:49

GoogleCodeExporter commented 9 years ago
It's version 0.3.1 of mptt: 
http://github.com/django-mptt/django-mptt/blob/0.3.1/mptt/managers.py#L230

In the master branch it seems to be fixed. However there's another line which 
doesn't work in Python 2.4.*: 
http://github.com/django-mptt/django-mptt/blob/master/mptt/models.py#L232
http://github.com/django-mptt/django-mptt/blob/master/mptt/models.py#L255

Original comment by jgel...@gmail.com on 28 Sep 2010 at 1:27

GoogleCodeExporter commented 9 years ago
Thanks. Fixed in master:

http://github.com/django-mptt/django-mptt/commit/1cf24adb6ddfa4d39ec7da3f0427a91
59f50339a

Can you try that out and let me know if you find any more incompatibilities?

Hopefully I'll get around to building a VM with Python 2.3 soon to test stuff 
like this :)

Original comment by craig.ds@gmail.com on 28 Sep 2010 at 2:07

GoogleCodeExporter commented 9 years ago
I don't get any errors anymore :) I can't test everything however, my code is 
still based around version 0.3.1. 

I'll let you know if I find more.

Original comment by jgel...@gmail.com on 28 Sep 2010 at 2:48