search

google-code-export / django-page-cms

Automatically exported from code.google.com/p/django-page-cms
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Cannot preview draft pages #181

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I just realized that it is no longer possible to preview draft pages if
logged in as staff. This was fixed before in Issue 93, but changes since
then introduced new code which prevents it again. The attached patch solves
the issue.

Original issue reported on code.google.com by jacques....@gmail.com on 6 Nov 2009 at 7:34

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks a lot! Is it possible to create a little test to avoid regression on 
this issue?

Original comment by batiste....@gmail.com on 6 Nov 2009 at 7:39

GoogleCodeExporter commented 9 years ago 
Sure, I was just running the django-page-cms tests for the first time for issue 
156.
Should post one shortly.

Original comment by jacques....@gmail.com on 6 Nov 2009 at 7:52

GoogleCodeExporter commented 9 years ago 
Here is another patch including a regression test. The test also ensures the 
page is
not visible if the user is not logged in or logged in as a non-staff user. For 
this a
404.html template and a new user was added to the fixtures.

Original comment by jacques....@gmail.com on 6 Nov 2009 at 8:25

Attachments:

GoogleCodeExporter commented 9 years ago 
Sorry wrong patch, here is the correct one.

Original comment by jacques....@gmail.com on 6 Nov 2009 at 8:26

Attachments:

GoogleCodeExporter commented 9 years ago 
You patch has been applied:

http://code.google.com/p/django-page-cms/source/detail?r=758

Thanks for the test!

Original comment by batiste....@gmail.com on 7 Nov 2009 at 1:45