search

google-code-export / django-photologue

Automatically exported from code.google.com/p/django-photologue
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

move date_taken out of ImageModel #109

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This is a small issue with an otherwise really fine piece of software, but 
seems worth looking at.

If ImageModel is an abstract base class for all types of images, the date_taken 
attribute seems out 
of place, since it makes the assumption that the image is a photograph. Would 
it make sense to 
move date_taken to the Photo model?

Original issue reported on code.google.com by dmee...@gmail.com on 5 Apr 2009 at 5:30

GoogleCodeExporter commented 9 years ago 
In fact, you could just switch date_added and date_taken between the Photo 
model and the ImageModel model.

Original comment by dmee...@gmail.com on 5 Apr 2009 at 5:33

GoogleCodeExporter commented 9 years ago 
And move the exif function to the Photo model as well.

Original comment by dmee...@gmail.com on 5 Apr 2009 at 5:35

GoogleCodeExporter commented 9 years ago 
After a little searching, I see that this is taken care of with ImageKit. looks 
good!

Original comment by dmee...@gmail.com on 5 Apr 2009 at 5:47

GoogleCodeExporter commented 9 years ago 
This kind of thing is no longer an issue in django-imagekit. If you're using 
the ImageModel abstract class I'd 
strongly encourage you to look at it:

http://hg.driscolldev.com/django-imagekit/

You can also look at the Photologue 3.x branch to see how it uses ImageKit to 
duplicate the functionality of 
Photologue 2.x.

Original comment by justin.d...@gmail.com on 5 Apr 2009 at 5:49

GoogleCodeExporter commented 9 years ago 
Didn't see you last post. Let me know if you run into any issues with ImageKit.

Original comment by justin.d...@gmail.com on 5 Apr 2009 at 5:52

GoogleCodeExporter commented 9 years ago

Original comment by justin.d...@gmail.com on 27 Apr 2009 at 4:14