Photo.is_public not respected

[GoogleCodeExporter]

Hi,

I've found a number of cases where the is_public field on Gallery and on
Photo was not respected.
Attached is a diff file to fix this.

Richard

Original issue reported on code.google.com by richardb...@gmail.com on 8 Feb 2008 at 8:28

Attachments:

• public_photos.diff

[GoogleCodeExporter]

Oops, the patch that I just sent in doesn't quite work. When listing a gallery, 
it
will include all known public photos - not just those that belong to that 
gallery.
I'm not sure on how to best get round this - amending my patch to rename 
is_public to
get_query_set in the PhotoManager class fixes the issue, but I feel that 
changing the
default manager is not a good idea.
I'll have a think about this and resubmit another patch.
Richard

Original comment by richardb...@gmail.com on 9 Feb 2008 at 1:02

[GoogleCodeExporter]

Re-submitting a better patch.

Original comment by richardb...@gmail.com on 9 Feb 2008 at 1:26

Attachments:

• public_photos.diff

[GoogleCodeExporter]

Found another case where is_public was not respected (in photo_detail.html, all
galleries are listed instead of just the public ones).
Rather than submitting a new patch, I'm resubmitting the previous one with all 
the
amended code.

Richard

Original comment by richardb...@gmail.com on 11 Feb 2008 at 8:02

Attachments:

• public_photos3.diff

[GoogleCodeExporter]

I've applied your latest patch and found a couple more template instances that 
needed
updating. Thanks for the help.

Original comment by justin.d...@gmail.com on 19 Feb 2008 at 5:43

• Changed state: Fixed