google-code-export / django-profile

Automatically exported from code.google.com/p/django-profile
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

idea: send messages with request.user.message_set.create instead of action_done views #43

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
I have a basic patch that replaces the action_done views with
django.contrib.auth messages.

pros:

 * makes the UI and code a bit simpler
 * consistent with other apps

cons:

 * prevents customizing messages in templates (still possible with
translations)
 * messages don't have a class[1], so it's necessary to wrap them like <div
class="notice">Message</div>

[1] http://code.djangoproject.com/ticket/3995

Original issue reported on code.google.com by ericd...@gmail.com on 4 Dec 2008 at 4:48

GoogleCodeExporter commented 9 years ago
Seems a necessary change, having multiple templates just to say "ok, this worked
well" is a waste of time.

Let's do it! Can you post the patch you've done?

Original comment by david.ru...@gmail.com on 4 Dec 2008 at 7:43

GoogleCodeExporter commented 9 years ago
i have it stashed in my git repository, will clean it up and post it. there is 
at
least one message that has class="notice" (when a confirmation email is sent). 
Should
we just drop the class for now and wait for Django #3995?

Original comment by ericd...@gmail.com on 5 Dec 2008 at 12:32

GoogleCodeExporter commented 9 years ago
thanks for all your help, btw David! I would be glad to join the project. 
(although I
may disappear occasionally)

Original comment by ericd...@gmail.com on 5 Dec 2008 at 12:34

GoogleCodeExporter commented 9 years ago
I have added you to the project members of the project, so you can commit to 
the svn
if you want. Feel free to make changes whenever you can or want. Actually only 
you
and I are working on evolving the project.

I would add the class="notice" for the moment, until the ticket 3995 comes.

Original comment by david.ru...@gmail.com on 5 Dec 2008 at 10:49