search

google-code-export / django-values

Automatically exported from code.google.com/p/django-values
1 stars 1 forks source link

BooleanValue does not change from True to False #18

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Create a BooleanValue setting
2. In the admin check the value and save
3. Uncheck the value and save

What is the expected output? What do you see instead?
I expect the checkbox to be unchecked, but it remains checked. Also there
is no message that any change has occured

What version of the product are you using? On what operating system?
the latest checkout from svn. ubuntu 9.10

Please provide any additional information below.
I looked at the source: views.py line 34 and noticed the line:
if value and current_value != setting.to_python(value):
 ...
however, if the checkbox was just unchecked (changed state from checked to
unchecked), value = False, current_value = True, setting.to_python(value) =
False
so we have if False != False which gives False and so the rest of the 
processing is skipped for this value, hence the value does not change ...

Original issue reported on code.google.com by bayokra...@gmail.com on 27 Feb 2010 at 8:11