google-code-export / dkpro-core-asl

Automatically exported from code.google.com/p/dkpro-core-asl
0 stars 0 forks source link

Modules languagetool und decompounding use different versions of jwordsplitter #586

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Modules languagetool und decompounding use different versions of jwordsplitter 
and can thus not really be used in a pipeline together.

If there is no special need to use a specific version, we should use the same 
version in both modules.

Original issue reported on code.google.com by torsten....@gmail.com on 28 Jan 2015 at 12:53

GoogleCodeExporter commented 9 years ago
jwordsplitter is a transitive dependency of languagetool, thus the 
decompounding should be updated to the same version that languagetool uses.

Original comment by richard.eckart on 28 Jan 2015 at 12:56

GoogleCodeExporter commented 9 years ago
I tried to look into this, but in a fresh checkout of dkpro core, about half of 
the tests in decompounding fail (without changing anything). Many tests do not 
find the models that are loaded from class path.
Any special tricks to make that work.

Original comment by torsten....@gmail.com on 29 Jan 2015 at 1:54

GoogleCodeExporter commented 9 years ago
Hm. The tests work on Jenkins, so they should work for you as well. 

But I have the same problem in Eclipse.  I think Pedro was last working on the 
resource loading in the decompounting. Pedro, you have an idea?

Original comment by richard.eckart on 29 Jan 2015 at 2:39

GoogleCodeExporter commented 9 years ago
Hey, sorry for the late response. Tested at my local machine and the unit tests 
worked. And as Richard mentioned, the build on jenkins does not indicate any 
error.

Original comment by pedrobss...@gmail.com on 3 Feb 2015 at 9:24

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3302.

Updating jword splitter version.

Original comment by pedrobss...@gmail.com on 3 Feb 2015 at 9:26

GoogleCodeExporter commented 9 years ago
Thanks for the update.
It is still interesting that it works for you (and on jenkins) while it does 
not work here with a fresh checkout of Core.
Maybe you have some old snapshots in your repository that make this work that 
you don't get?
Or do you need any additional steps to prepare this module?

Original comment by torsten....@gmail.com on 4 Feb 2015 at 9:18

GoogleCodeExporter commented 9 years ago
I have deleted all "model" and "upstream" artifacts form my local repository, 
updated the projects and ran the tests again. Now it works for me.

TZ: I suspect *somebody* has "fixed" a model by re-uploading it to the repo 
without changing its version. You probably still have the "broken" version in 
your local repo.

I assume this was not merged into the 1.7.1 branch yet - setting to NeedsMerge.

Original comment by richard.eckart on 4 Feb 2015 at 1:12

GoogleCodeExporter commented 9 years ago
Thanks - works for me now :)

Original comment by torsten....@gmail.com on 4 Feb 2015 at 1:28

GoogleCodeExporter commented 9 years ago
This issue was updated by revision r3303.

Making the merge.

Original comment by pedrobss...@gmail.com on 6 Feb 2015 at 2:57

GoogleCodeExporter commented 9 years ago

Original comment by pedrobss...@gmail.com on 9 Feb 2015 at 1:03