search

google-code-export / dkpro-tc

Automatically exported from code.google.com/p/dkpro-tc
Other
1 stars 0 forks source link

Generalize return type of FeatureStore.getFeatureNames() #198

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently, FeatureStore.getFeatureNames() returns TreeSet<String>. I suggest we 
generalize that to SortedSet<String>, so another implementations can be used. 
This should not change any functionality.

Original issue reported on code.google.com by ivan.hab...@gmail.com on 15 Oct 2014 at 11:44

GoogleCodeExporter commented 9 years ago 
Or should be all features always sorted alphabetically? I haven't found any 
evidence for that in tests.

Original comment by ivan.hab...@gmail.com on 15 Oct 2014 at 11:47

GoogleCodeExporter commented 9 years ago 
I don't remember the details, but I changed to sorted features as there was 
some side effect when feature offsets change.

Or maybe it was just because it looks nicer in the training file? :)

I really need to get a better memory ...

Original comment by torsten....@gmail.com on 15 Oct 2014 at 12:00

GoogleCodeExporter commented 9 years ago 
Look better, I agree :)

So let's keep it that way, because these unknown side effects may cause some 
terrible consequences... (But: I refactored that to SortedSet, run all tests, 
and none failed...)

Original comment by ivan.hab...@gmail.com on 15 Oct 2014 at 12:07

GoogleCodeExporter commented 9 years ago 
I think we're not going to take action here.

Original comment by daxenber...@gmail.com on 4 Nov 2014 at 1:40