google-code-export / exposong

Automatically exported from code.google.com/p/exposong
GNU General Public License v3.0
0 stars 1 forks source link

List for points in backgrounds (Theme Editor) #165

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Currently you can only add new points in radial or gradient backgrounds, but 
not remove them.
To do so, we need to change the points to a list.

I'm unsure how this should look like though. Should it be a list like the one 
for the backgrounds where you select a point and you see the widgets for that 
point or should the widgets be embedded into the list?

Original issue reported on code.google.com by s.mehrbrodt on 1 Jun 2011 at 1:24

GoogleCodeExporter commented 9 years ago
I was thinking it would be either like the background selector, or it could be 
a popup (look at the lyrics editor for author/songbook/etc) if that would be 
easier.

You could see if you could have a color button/spinner columns inside of a 
treeview. Just an idea.

Original comment by bradleelandis on 1 Jun 2011 at 4:04

GoogleCodeExporter commented 9 years ago
This is one of the main holdups until we can start getting documentation done. 
I don't mind taking over this issue if you don't have the time, just let me 
know.

Original comment by bradleelandis on 12 Oct 2011 at 8:41

GoogleCodeExporter commented 9 years ago
I am still not sure how you want this to be.
I think it's important to have the color button and spinner directly accessible 
and not in an extra dialog.

Maybe we can have a list with the current color button and spinner shown next 
to it:
_________________________
| |+| |-|               |
------------------------
|Point 1 | ColorButton  |
|Point 2 |              |
|̣̣Point 3 | Spinner      |
-------------------------
| Angle   AngleSpinner  |
-------------------------

Original comment by s.mehrbrodt on 13 Oct 2011 at 11:37

GoogleCodeExporter commented 9 years ago
I noticed that you used "Length", but it's more like "Position (%)". It can 
become out of order (e.g. where color0 is actually after color1), but the best 
way to handle it now is to update the order when the user clicks on the 
gradiant in the bg list again. If it doesn't currently do this, then that's 
okay too. Maybe next release we can redesign it.

If a list would support the button and spinners, you can change it to this:

[+] [-] [down] [up]  [AngleSpinner]
--------------------------------------
| Point 1 | ColorButton | PosSpinner |
--------------------------------------

Down/up would swap the colors, but not the position to keep them in order.

If you want to keep it the way it is, I would be fine if you just added a 
delete button to each point.

Original comment by bradleelandis on 13 Oct 2011 at 2:10

GoogleCodeExporter commented 9 years ago
I think I tried to do the widgets in a list earlier, but couldn't get it done. 
So for now, I have just added a delete button to each point (only appears when 
more than two points exist): rbf43b3329ed3

You can close this issue if it's ok for you.

Original comment by s.mehrbrodt on 17 Oct 2011 at 9:27

GoogleCodeExporter commented 9 years ago
This looks good. Do you want to change the "Length" field to be called 
"Position"? It makes more sense to me that way. That's all that I know of that 
might need changing.

Original comment by bradleelandis on 19 Oct 2011 at 5:27

GoogleCodeExporter commented 9 years ago
I think I did that already…

Original comment by s.mehrbrodt on 19 Oct 2011 at 8:15

GoogleCodeExporter commented 9 years ago
Oh I see I changed "Length" to "Position" only for gradient backgrounds, not 
for radial gradient backgrounds.
I fixed it now.

Original comment by s.mehrbrodt on 27 Oct 2011 at 6:23