google-code-export / fanart-handler

Automatically exported from code.google.com/p/fanart-handler
1 stars 0 forks source link

Uninstall does not remove Fanarthandler.db3 file and results in errors on Reinstall #1

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What version of the plugin are you using?
RC1

What steps will reproduce the problem?
Uninstall Fanart Handler using MP Extenstions Installer
All files are removed except fanarthandler.db3

Reinstalling Fanart Handler then installs fanart handler.org and 
FanartHandler.db3-journal however error.log shows:

2010-01-18 18:08:07.266069 [ERROR][34]: SQLiteClient: FanartHandler.db3 
cmd:sqlite3_prepare16:pvm=null err:ERROR detailed:near "s": syntax error 
query:DELETE FROM Movie_Fanart WHERE Disk_Image = 'C:\ProgramData\Team 
MediaPortal\MediaPortal\Thumbs\Skin FanArt\movies\Mr  Magorium's Wonder 
Emporium.jpg';
2010-01-18 18:08:07.287552 [ERROR][34]: SQLiteClient: FanartHandler.db3 
cmd:sqlite3_prepare16:pvm=null err:ERROR detailed:near "s": syntax error 
query:DELETE FROM Movie_Fanart WHERE Disk_Image = 'C:\ProgramData\Team 
MediaPortal\MediaPortal\Thumbs\Skin FanArt\movies\One Flew Over the 
Cuckoo's Nest.jpg';

Obviously the database is intact and looking for indexed items which are 
now missing.

What is the expected output? What do you see instead?
Expect the db3 file to be removed as well.

Glad to report the first issue! Sorry

Dadeo

Original issue reported on code.google.com by dcarson...@gmail.com on 18 Jan 2010 at 12:43

GoogleCodeExporter commented 9 years ago
Hi,

Tank you for this report. It actually shows two bugs ;) the one you describe 
but also 
the delete funtion and the use of ' in the filename. I will fix both.

best regards
cul8er

Original comment by markus_e...@telia.com on 18 Jan 2010 at 1:16

GoogleCodeExporter commented 9 years ago
Actually I don't find an option in the MPI installer to specify what should be 
deleted 
on an uninstall... 

Original comment by markus_e...@telia.com on 18 Jan 2010 at 1:19

GoogleCodeExporter commented 9 years ago
I don't know it well, but I suspect it only removes files installed via the 
installer!  Drat!@

I have not used the new MPEI Extension Installer V2 that Dukus is working on 
but I 
think he added many things, so perhaps that is now supported? Crossing fingers! 

Original comment by dcarson...@gmail.com on 18 Jan 2010 at 1:27

GoogleCodeExporter commented 9 years ago
I have now fixed the ' character causing the SQL engine to think that is the 
end of the 
sql statement ;) This has probably caused many more problems when displayign 
fanart for 
artists with the ' character in the filename or artist name.

Original comment by markus_e...@telia.com on 18 Jan 2010 at 1:38

GoogleCodeExporter commented 9 years ago
This will not be an easy issue to resolve. Current MPI installer does not allow 
uninstalling specific files. Only uninstalling the files that it originally 
installed. 
And as the MPI contains FanartHandler.org and not the FanartHandler.db3 (that 
is 
generated by the plugin on first use) I see no way of solving this. I will see 
if I can 
find another way of handling the database but this will be a low priority.

Original comment by markus_e...@telia.com on 21 Jan 2010 at 7:42

GoogleCodeExporter commented 9 years ago
Understood.  I only posted this to ensure you were aware of the problem. Who 
will 
ever want to unintall the fanart handler?  :) However, perhaps it would be wise 
to 
add a note to the Installation Wiki Page that if you do uninstall, you must 
delete 
the db3 file manually.

Original comment by dcarson...@gmail.com on 21 Jan 2010 at 8:28

GoogleCodeExporter commented 9 years ago
Hi,

Good suggstion. I will add this to the Wiki. And if you want I can add you to 
the 
people that can edit the wikis on this site if you want. If so please let me 
know.

cheers
cul8er

Original comment by markus_e...@telia.com on 21 Jan 2010 at 10:13

GoogleCodeExporter commented 9 years ago
Sure, no problem. And you can also add aMPed to the list of skins that support 
the 
plugin if you wish. I should be able to release it tonight - at last! I am 
sooooo 
tired!

Original comment by dcarson...@gmail.com on 21 Jan 2010 at 11:58

GoogleCodeExporter commented 9 years ago
Hi,

Will be very exiting to see what you have done with aMPED. I will sure add it 
to 
skins that support the plugin. Good suggestion. Will do that as soon as you 
release 
the new version. I just gave you edit permissions to all the wikis so please 
feel 
free to add/change whatever.

best regards
cul8er

Original comment by markus_e...@telia.com on 21 Jan 2010 at 12:44

GoogleCodeExporter commented 9 years ago

Original comment by markus_e...@telia.com on 24 Jan 2010 at 1:05

GoogleCodeExporter commented 9 years ago
I will close this issue as it cannot be resolved using the current MPI 
installer. Will 
be sure to try to fix it with the new installer when MP1.1 is released.

best regards
cul8er

Original comment by markus_e...@telia.com on 2 Feb 2010 at 2:16