search

google-code-export / fanart-handler

Automatically exported from code.google.com/p/fanart-handler
1 stars 0 forks source link

Default fanart handling if fanart not found #15

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
If fanart handler let a user select a default backdrop in the plugin. Then 
the plugin manages to display the backdrop and fade in and out to it nicely, 
when no fanart is available. Of course this would only apply when a user had 
fanart on for that window.

Original issue reported on code.google.com by markus_e...@telia.com on 24 Jan 2010 at 1:27

GoogleCodeExporter commented 9 years ago 
I noticed that if no fanart is found the current behaviour is that no image is 
shown.
 This is probably ok, because it is up to the skin designer to put a background image
below the fanart layer, so perhaps this enhancement is not really needed.  Also 
it
does actually fade to transparent, so you get a nice fade between the background
image and the fanart when it appears/dissappears.

(Originally i thought the fanart handler showed a black image, but I notice 
that I
can just insert a a custom default background below the fanart controls in the 
skin's
.xml file)

Original comment by kiwijung...@gmail.com on 25 Jan 2010 at 12:21

GoogleCodeExporter commented 9 years ago 
I vote for this issue for two reasons:
1. It lets users select their own default backdrop if they don't like the skin 
provided one (not all users are ready to skin using xml files
2. It can be tricky to define default backdrops in a skin so that the default 
backdrops fade between the fanart and the default images in all cases, 
especially if 
you wish to define backdrops in a common window xml

Original comment by dcarson...@gmail.com on 26 Jan 2010 at 5:23

GoogleCodeExporter commented 9 years ago

Original comment by markus_e...@telia.com on 27 Jan 2010 at 12:32

GoogleCodeExporter commented 9 years ago 
When the plugin fades between two artist images, you can see the underlying 
image.

eg. Now Playing Full Screen Fanart
Skin has a default image of a kangaroo underneath the fanart image controls.

User presses >SKIP> to skip to next track.
I can see the underlying kangaroo between the fades of fanart.

I guess this could be avoided by having a solid black fullscreen image above the
kangaroo and this image has conditional visibility based on the fanart image 
being
present, not sure if this is possible or not.

Original comment by kiwijung...@gmail.com on 27 Jan 2010 at 1:17

GoogleCodeExporter commented 9 years ago 
Hi kiwijunglist,

Have you tried after changing the code I added in the other thread? Didn't that 
solve 
this problem?

Anyway, I'm working on implementing the default backdrop into the plugin. Will 
be 
available for 1.1 RC2.

cheers
cul8er

Original comment by markus_e...@telia.com on 27 Jan 2010 at 8:07

GoogleCodeExporter commented 9 years ago 
done and will be available in v1.1 RC2

Original comment by markus_e...@telia.com on 28 Jan 2010 at 6:53