search

google-code-export / fanart-handler

Automatically exported from code.google.com/p/fanart-handler
1 stars 0 forks source link

Defect: Max images per artist setting ignored until you restart the program #42

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?

Manually delete all the plugin files
Fresh installation of plugin
Change max image per artist from 3 (Default) to 1
Run the scraper

What is the expected output? What do you see instead?

Expect 1 image per artist, I see 3 images downloaded per artist

What sversion of the Fanart Handler plugin are you using?

Fanart Handler 1.1

Original issue reported on code.google.com by kiwijung...@gmail.com on 1 Feb 2010 at 8:00

GoogleCodeExporter commented 9 years ago 
It appears that changes are not saved before scraping, so it uses info in the 
.xml.

May I suggest that instead of 'Save and Exit' and 'Cancel' options, you could 
have
'Exit', and then ask to 'Save Changes' or 'Quit without Saving'. Also in 
Manager,
ensure that changes are saved first when the scrape button is selected...

Chuck

Original comment by that...@2bitstudio.com on 1 Feb 2010 at 9:07

GoogleCodeExporter commented 9 years ago

Original comment by markus_e...@telia.com on 2 Feb 2010 at 7:01

GoogleCodeExporter commented 9 years ago 
fixed

Original comment by markus_e...@telia.com on 2 Feb 2010 at 9:17

GoogleCodeExporter commented 9 years ago 
This is till an issue. Changes are not saved until exit from handler and MP 
configs.
If scraping immediately after making changes, and before exiting, the old 
settings
are used. 

I had changed the value to 10 artist images, whereas there were only scraped 3, 
on an
artist I knew to have at least 6 images.

Original comment by that...@2bitstudio.com on 3 Feb 2010 at 2:49

GoogleCodeExporter commented 9 years ago 
Hi,

Did you also press the "reset scrape" button. Otherwise no scrape will occur as 
the 
artists are already marked as done.

So to verify that the issue is resolved you need to;
1. Have setting like max 2 images
2. Do scrape
3. Change max to 3 images
4. Press "reset scrape" button
5. do scrap

all without saving and exiting.

does this work?

cheers
cul8er

Original comment by markus_e...@telia.com on 3 Feb 2010 at 7:00

GoogleCodeExporter commented 9 years ago 
I did use the 'reset scrape'

The original setting was max 3 images, I set to max 10 images before I entered 
the
manage images section. I had also hit the 'save' button before going to manage
images, but did not exit.

I just rechecked.

The setting was max 10 images from the last saved settings and scrape.
I set to max 2 images. and hit the save button... and 'ok'
Went to manage images. Deleted all images. Hit 'Reset' ... and 'ok'
started scrape. I was still getting more than 2 images for those artists that 
had
more than 2. 

ABBA = 3, Alice Cooper = 7, etc.

The setting is used only after save and exit, and exit from MP config.

Original comment by that...@2bitstudio.com on 3 Feb 2010 at 7:23

GoogleCodeExporter commented 9 years ago 
Hi,

Big thank you for your feedback. I finally found the issue. I had change this 
in one 
occurance but it was actually two places I needed to change. Should work in 
v1.3 Thank 
you for persisting ;)

best regards
cul8er

Original comment by markus_e...@telia.com on 3 Feb 2010 at 8:05

GoogleCodeExporter commented 9 years ago

Original comment by markus_e...@telia.com on 3 Feb 2010 at 10:08

GoogleCodeExporter commented 9 years ago 
Hi,

Please test if this issue is resolved in version 1.3 RC1.

Link to 1.3 RC1:
http://code.google.com/p/fanart-handler/downloads/detail?
name=fanarthandler_1_3_RC1.MPE1

best regards
cul8er

Original comment by markus_e...@telia.com on 4 Feb 2010 at 7:13

GoogleCodeExporter commented 9 years ago 
This is working now. No need to exit plug-in to change value in scrape.

I even stopped the scrap midway and reset the max number, saved and started new
scrape. Worked wonderfully.

Thank you

Original comment by that...@2bitstudio.com on 4 Feb 2010 at 2:20

GoogleCodeExporter commented 9 years ago 
I think it should auto save whenever you change an option.

Original comment by kiwijung...@gmail.com on 4 Feb 2010 at 2:41

GoogleCodeExporter commented 9 years ago 
Hi,

No, I want save to be a manual thing. One user may want to change settings for 
current session only another want it to be persistent. I will leave this as it 
is now 
as it is working as expected.

But you do not have to press save to make it work. Just change the value, press 
reset 
and then do a new scrape.

Thank you all for your help.

cheers
cul8er

Original comment by markus_e...@telia.com on 4 Feb 2010 at 3:02