google-code-export / fanart-handler

Automatically exported from code.google.com/p/fanart-handler
1 stars 0 forks source link

scraping indication stays on during Now Playing #54

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
after updating to 1.3 RC 1 My scraping indicator stays on when I'm in Now
Playing. It doesn't go off after scraping (I'm assuming it has stopped
scraping search) for each artist, even when fanart has obviously been
retrieved. It constantly reads "scraping  %" and does not indicate a value,
before, it would come on, show "scraping 50 %", then go off

I then turned off Now Playing Scrape and the indicator is still on when in
Now Playing. It constantly reads "scraping  %"

I have not changed my skin from v1.1 

It looks like <ID>91919280</ID> is malfunctioning.

What sversion of the Fanart Handler plugin are you using?
1.3 RC 1

What skin and version of the skin are you using?
Blue3 mod, MP 1.0.2 version

Please provide any additional information below.

Original issue reported on code.google.com by that...@2bitstudio.com on 4 Feb 2010 at 10:48

GoogleCodeExporter commented 9 years ago
Scraping indicator seems to operate correctly for full db scrape in Now Playing,
showing "scraping (value) %"

Original comment by that...@2bitstudio.com on 5 Feb 2010 at 3:18

GoogleCodeExporter commented 9 years ago
Hi,

Please attach your xml file so that I can see what is going on.

Also make sure you have "<visible>no</visible>" on the 91919280 control.

best regards
cul8er

Original comment by markus_e...@telia.com on 5 Feb 2010 at 9:27

GoogleCodeExporter commented 9 years ago
Should the dummy control for 91919280 be used twice in the xml?  In the wiki it 
is
shown twice; once with and once without visibility.  In the example code for
displaying scraping progress it was left out.  That's the one I used.  It worked
correctly until 1.3 rc 1. When I added the <visibilty>no</visibility> then it 
did not
display at all when scraping. Is it intended to show during full db scrape and 
not
during now playing artist scrape?

Original comment by that...@2bitstudio.com on 5 Feb 2010 at 1:54

GoogleCodeExporter commented 9 years ago
Actually... to think of it... having the progress show 50% during now playing 
scrape
didn't seem right. but it displayed that it was scraping (which is what I 
thought I
wanted) during now playing

Original comment by that...@2bitstudio.com on 5 Feb 2010 at 2:48

GoogleCodeExporter commented 9 years ago
Hi,

The 91919280 should only exist once. I think I need your skin file. I cannot 
reproduce 
this problem using my skin files.

best regards
cul8er

Original comment by markus_e...@telia.com on 5 Feb 2010 at 3:13

GoogleCodeExporter commented 9 years ago
in this version, without <visibility>no</visibility> the 'playing artist scrape'
displayed % with no value, but constantly. In the previous version, the 'playing
artist scrape' displayed 50% but only momentarily (during 'playing artist 
scrape')

With <visibility>no</visibility> set then progress does not display during 
'playing
artist scrape', but it does during full db scrape. 

I wanted to know when scraping was occurring in both scraping instances, other 
than
just seeing fanart magically appear, but I can live without it.

So maybe this is a non-issue ... if progress display is only intended for full 
db scrape.

Original comment by that...@2bitstudio.com on 5 Feb 2010 at 4:33

GoogleCodeExporter commented 9 years ago
Hi,

Try in Last.FM and play an artist you have no fanrt for and not in your music 
database. 
If you skin supports it you should see the percent increasing from 0 to 50 to 
100.

best regards
cul8er

Original comment by markus_e...@telia.com on 5 Feb 2010 at 10:37

GoogleCodeExporter commented 9 years ago
I'm not getting any indication of scraping in Last.FM. for playing-artist 
scrape. The
image comes in, but no scraping progress %. 

MyRadioLastFM.xml attached. The scraper progress code is on the bottom. I think 
I got
it right. Let me know.

Chuck

Original comment by that...@2bitstudio.com on 5 Feb 2010 at 11:04

Attachments:

GoogleCodeExporter commented 9 years ago
Hi,

I see that I have made an error in the wiki about this. I have now changed it. 
Please 
try this code instead (no animation tags, font color etc).

        <control>
            <description>DUMMY CONTROL FOR FANART HANDLER IS SCRAPING 
VISIBILITY CONDITION</description>
            <type>label</type>
            <id>91919280</id>
            <posX>0</posX>
            <posY>0</posY>
            <width>1</width>
                        <visible>no</visible>
        </control>  

        <control>
            <description>Scraping Header</description>
            <type>label</type>
            <id>0</id>
            <posX>690</posX>
            <posY>459</posY>
                        <width>200</width>
                        <textcolor>90ffffff</textcolor>
                        <font>font14</font>
                        <label>scraping</label>
                        <align>right</align>
            <visible>control.isvisible(91919280)</visible>
        </control>      

        <control>
            <description>Scraping Percent Complete</description>
            <type>label</type>
            <id>0</id>
                        <posX>695</posX>
                        <posY>459</posY>
                        <width>96</width>
                        <textcolor>90ffffff</textcolor>
                        <font>font14</font>
            <label>#fanarthandler.scraper.percent.completed %</label>
            <align>left</align>
            <visible>control.isvisible(91919280)</visible>
        </control> 

Let me know if it works. Also, before trying use the attached file.

best regards
cul8er

Original comment by markus_e...@telia.com on 5 Feb 2010 at 11:34

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by markus_e...@telia.com on 5 Feb 2010 at 11:36

GoogleCodeExporter commented 9 years ago
The scraping in manager is going smoothly thus far, 1/3 through with max 10 
images
per artist. It has already gotten past the initial hang area (the second image 
of an
artist caused the hang the last time)... so far so good.

I haven't run MP yet to check out the progress labels. I Will, after initial 
scraping
is done.

Thank you very much.

Original comment by that...@2bitstudio.com on 6 Feb 2010 at 12:23

GoogleCodeExporter commented 9 years ago
Last.FM only shows 'scraping 50 %' during 'playing-artist scrape' I don't see a
progression. I used your changes to the xml.

Original comment by that...@2bitstudio.com on 6 Feb 2010 at 1:33

GoogleCodeExporter commented 9 years ago
Hi,

You are correct. For now it only displays 50% and then dissapears when done. I 
will see 
if this can be improved later. But the issue is now closed as it shows and the 
hides 
when now scraping is done.

best regards
cul8er

Original comment by markus_e...@telia.com on 6 Feb 2010 at 1:02