search

google-code-export / fanart-handler

Automatically exported from code.google.com/p/fanart-handler
1 stars 0 forks source link

Enhancement: Strip "720P" "1080P" strings from image name after search htbackdrops before deciding on match #67

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Lots of images on htbackdrops titled as
"%artist% 1080P.jpg" eg. "Blur 1080P.jpg"

So I could do a search for "Blur"

and it would come up with
Blur (720P).jpg
Blur_1080P.jpg

Unfortunately neither of those files are a match

I propose you strip any of the following strings in this order from the
htbackdrop image name after you've done the search, but before you decide
on a match.

"(1080P)"
"(720P)"
"1080P"
"720P"
"1080"
"720"
"_"

Original issue reported on code.google.com by kiwijung...@gmail.com on 15 Feb 2010 at 4:19

GoogleCodeExporter commented 9 years ago

Original comment by markus_e...@telia.com on 15 Feb 2010 at 6:47

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Actually this method might be better
strip any of these strings in this order.

"-(1080P)"
"-(720P)"
"-[1080P]"
"-[720P]
"_(1080P)"
"_(720P)"
"_[1080P]"
"_[720P]
" (1080P)"
" (720P)"
" [1080P]"
" [720P]
"(1080P)"
"(720P)"
"[1080P]"
"[720P]
"-1080P"
"-720P"
"-1080"
"-720"
"_1080P"
"_720P"
"_1080"
"_720"
" 1080P"
" 720P"
" 1080"
" 720"
"1080P"
"720P"
"1080"
"720"

Original comment by kiwijung...@gmail.com on 15 Feb 2010 at 7:47

GoogleCodeExporter commented 9 years ago 
Hi,

I'm unable to reproduce this. If I goto htbackdrops and enter blur in the 
search 
textbox I get 6 images. One of these are DrAlban Blur Fx so this is not the 
artist we 
look for. Of these 5 images only 3 are backdrops (the other two are thumbs). I 
have a 
blur song on my MP client and it correctly downloads all three images.

Please let me know what you do when you get this error so that I can 
investigate.

best regards
cul8er

Original comment by markus_e...@telia.com on 15 Feb 2010 at 10:18

GoogleCodeExporter commented 9 years ago 
Oh sorry blur was an example that I made up, to illustrate my point.  Here are 
some
real examples.

Try "amon tobin"
5 backdrops, 4 images have " 720P" / " (720P)" suffix

Try "audio adrenaline"
3 backdrops, 1 image has "-1080" suffix

Try "Bayside"
1 backdrop, 1 image has " 1080P" suffix

Original comment by kiwijung...@gmail.com on 15 Feb 2010 at 10:26

GoogleCodeExporter commented 9 years ago 
Example of Amon Tobin search

Original comment by kiwijung...@gmail.com on 15 Feb 2010 at 10:29

Attachments:

GoogleCodeExporter commented 9 years ago 
Actualy amon tobin has 6 images, 4 are not useable because of the suffix

Original comment by kiwijung...@gmail.com on 15 Feb 2010 at 10:29

GoogleCodeExporter commented 9 years ago 
Now I understand, will continue this issue now ;)

Original comment by markus_e...@telia.com on 15 Feb 2010 at 10:30

GoogleCodeExporter commented 9 years ago 
This is now fixed. Please test the attached version and let me know if it works.

best regards
cul8er

Original comment by markus_e...@telia.com on 15 Feb 2010 at 8:41

Attachments:

GoogleCodeExporter commented 9 years ago 
will do, it will take me a couple of days to get back to you on this.  thank 
you for
the fix.

Original comment by kiwijung...@gmail.com on 15 Feb 2010 at 9:10

GoogleCodeExporter commented 9 years ago 
and other deviations of proper naming on HTBackdrops:

'16 Volt-FanArt1-1080P'
'16 Volt-FanArt2-1080P'
'2unlimited_emboss_720.jpg'
'7 Year Bitch Fanart 1080P'
'69 Eyes 1920x1080'
'Ace_of_Base_fanart_1920.jpg'

and multiple artist names:

'2pac / Tupac Shakur'
'123 / Raz Dwa Trzy / Adam Nowak'
'ALO(Animal Liberation Orchestra)'

Original comment by that...@2bitstudio.com on 15 Feb 2010 at 11:49

GoogleCodeExporter commented 9 years ago 
Tried the new fanart.dll 

Added a new mp3 file with artist="audio adrenaline" to music database
Ran the scraper, it didn't actually find any fanart for audio adrenaline.
Played the track in mediaportal
Now playing scraper found 2x fanart (but didn't get the 3rd image called
"audio_adrenaline-1080")

So for me it appears that this is still an issue.

Original comment by kiwijung...@gmail.com on 18 Feb 2010 at 1:25

GoogleCodeExporter commented 9 years ago 
ok i have a feeling that the scraper didn't find any fanart for audio adrenaline
intially, because after you add a new track to the mp music database you have 
to save
and close mp config, before fanart plugin can see the new artist/track in the 
database.

Original comment by kiwijung...@gmail.com on 18 Feb 2010 at 1:29

GoogleCodeExporter commented 9 years ago 
2nd test, added a dummy track with artist/album artist = Bayside.
Saved and closed MP Config.
Reopened MP Config, ran the scraper.
No fanart found (There is one image on htbackdrops called "Bayside 1080P")
Now playing scraper also failed to find this image.

So therefore this is still an issue using the fanarthandler.dll file attached 
to this
thread.

Original comment by kiwijung...@gmail.com on 18 Feb 2010 at 1:33

GoogleCodeExporter commented 9 years ago 
is it a problem not removing the space character at the end of the artist 
name?? just
a guess, that is what i would probably forget to do if I could program =)

Original comment by kiwijung...@gmail.com on 18 Feb 2010 at 1:39

GoogleCodeExporter commented 9 years ago 
Please test using v1.5 that will be available later today.

Original comment by markus_e...@telia.com on 23 Feb 2010 at 8:48

GoogleCodeExporter commented 9 years ago 
Hi,

Please test using the new version 1.5 (http://fanart-
handler.googlecode.com/files/fanarthandler_1_5.MPE1).

best regards
cul8er

Original comment by markus_e...@telia.com on 23 Feb 2010 at 2:03

GoogleCodeExporter commented 9 years ago 
Hi,

Have you had time to try this? I would like to close this so that I can release 
v1.5

Thank you for all your help.

best regards
cul8er

Original comment by markus_e...@telia.com on 25 Feb 2010 at 9:15

GoogleCodeExporter commented 9 years ago 
Hi,

Any news on this?

best regards
cul8er

Original comment by markus_e...@telia.com on 2 Mar 2010 at 5:50

GoogleCodeExporter commented 9 years ago

Original comment by markus_e...@telia.com on 3 Mar 2010 at 6:52

GoogleCodeExporter commented 9 years ago 
Hi sorry life has been too hectic for me to test this, and I'm going overseas 
next
week for 2 weeks so i just can't do it right now, sorry! =)

Original comment by kiwijung...@gmail.com on 10 Mar 2010 at 8:58

GoogleCodeExporter commented 9 years ago 
Closed due to lack of feedback. Will be reopened if the issue is not resolved.

best regards
cul8er

Original comment by markus_e...@telia.com on 7 Apr 2010 at 11:35