search

google-code-export / fancybox

Automatically exported from code.google.com/p/fancybox
1 stars 0 forks source link

Need to check if onCleanup exists [PATCH] #98

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 

line 324 of the fancybox js 

./fancybox/jquery.fancybox-1.3.4.js
ought to check if onCleanup is defined, Google Chrome complains...

 if (wrap.is(":visible") && currentOpts.onCleanup && false === currentOpts.onCleanup(currentArray, currentIndex, currentOpts)) {

What is the expected output? What do you see instead?

What version of the product are you using? On what operating system?
Linux, Google Chrome Stable 8.0.552.215 beta

Please provide any additional information below.

Original issue reported on code.google.com by cortland...@gmail.com on 10 Dec 2010 at 5:26

GoogleCodeExporter commented 9 years ago 
I'm now seeing this on Chrome, as well. Win7, 8.0.552.224 release. More 
specifically:

Uncaught TypeError: Object #<an Object> has no method 'onCleanup'

My code invokes fancybox on a .click() event, and it's invoked with an href 
arg, but no onCleanup arg.

Original comment by benjamin...@gmail.com on 20 Dec 2010 at 7:51

GoogleCodeExporter commented 9 years ago 
I have the same Problem on my Website, too.
I use Google Chrome 8.0.552.231 on Snow Leo 10.6.5

Original comment by christia...@gmail.com on 24 Dec 2010 at 12:44

GoogleCodeExporter commented 9 years ago 
Make sure that you're including jquery.fancybox-1.3.4.css instead of style.css. 
Solved it for me.

Original comment by andrew...@gmail.com on 5 Jan 2011 at 7:01

GoogleCodeExporter commented 9 years ago 
Even I have the same problem. I have included jquery.fancybox-1.3.4.css and the 
right js files. 

Please let me if anything else has to done apart from the steps mentioned in 
the site.

Original comment by janani.j...@gmail.com on 8 Jan 2011 at 12:55

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Just below that code a copy is made from selectedOpts.

Apparently it was refactored, but not properly.

Easiest fix is to move the lines
'           currentArray = selectedArray;
            currentIndex = selectedIndex;
            currentOpts = selectedOpts;
'
to before the if ( wrap.is("visible") ... statement.

Original comment by witsch...@gmail.com on 4 Apr 2011 at 3:10

GoogleCodeExporter commented 9 years ago 
i too facing these problem since two days... any one please help me

Original comment by muralikr...@gmail.com on 27 Apr 2013 at 5:44

GoogleCodeExporter commented 9 years ago 
metalico44@live.com

Original comment by metalico...@gmail.com on 15 Mar 2014 at 11:05