google-code-export / fanficdownloader

Automatically exported from code.google.com/p/fanficdownloader
0 stars 0 forks source link

Patch for /fanficdownloader/adapters/adapter_fanfictionnet.py #76

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Allow the adapter to accept urls from fanfiction.net without a subdomain as 
some forums and link aggregators strip out the subdomain from ff.net links. As 
this causes the ff.net servers to never complete the request the standard 'www' 
subdomain is added when necessary, mitigating a possible error in the 
processing later on.

Original issue reported on code.google.com by Eric.Hof...@gmail.com on 15 Jun 2014 at 2:31

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks.  I'll take a look at this, but it may be a few days.

Original comment by retiefj...@gmail.com on 15 Jun 2014 at 11:52

GoogleCodeExporter commented 9 years ago
I found some time today yet. :-)

While I appreciate the patch, that solution only fixes it for ffnet.  We have 
other sites that have switched to https, so I made a more general solution that 
will work with all sites.

A test version of the plugin is posted here:
http://www.mobileread.com/forums/showthread.php?p=2852242#post2852242

The change I made, if you're curious, is this:
https://code.google.com/p/fanficdownloader/source/detail?r=8f62eb3d7bd4618528c65
e59286a6be0751facd4

It works for me, so I'm going to call it fixed.  If the test version doesn't 
work for you, go ahead an add another note here or report it on the forum and 
I'll look at it again.

Original comment by retiefj...@gmail.com on 16 Jun 2014 at 1:45

GoogleCodeExporter commented 9 years ago
Thank you for your quick response. I didnt realise that other sites suffered 
from the same problem (or that there was already code to address a missing www 
subdomain). This is the kind of error response that keeps a codebase from 
spiraling out if control from well-meaning patches, so rock on ;)

Original comment by Eric.Hof...@gmail.com on 16 Jun 2014 at 11:09