google-code-export / ffmpegthumbnailer

Automatically exported from code.google.com/p/ffmpegthumbnailer
GNU General Public License v2.0
1 stars 1 forks source link

Height/Width inverted #39

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It seems there is a mistake in the code in the methods getHeight() and
getWidth(); they seem to be inverted...

Index: libffmpegthumbnailer/moviedecoder.cpp
===================================================================
--- libffmpegthumbnailer/moviedecoder.cpp   (revision 160)
+++ libffmpegthumbnailer/moviedecoder.cpp   (working copy)
@@ -153,7 +153,7 @@
 {
     if (m_pVideoCodecContext)
     {
-        return m_pVideoCodecContext->height;
+        return m_pVideoCodecContext->width;
     }

     return -1;
@@ -163,7 +163,7 @@
 {
     if (m_pVideoCodecContext)
     {
-        return m_pVideoCodecContext->width;
+        return m_pVideoCodecContext->height;
     }

     return -1;

Original issue reported on code.google.com by ubi...@gmail.com on 21 Sep 2009 at 1:42

GoogleCodeExporter commented 9 years ago
Good spot!

Luckily they aren't used in the thumbnailer, I committed the fix in svn.

Original comment by dirk.vdb on 21 Sep 2009 at 1:48