google-code-export / ffmpegthumbnailer

Automatically exported from code.google.com/p/ffmpegthumbnailer
GNU General Public License v2.0
1 stars 1 forks source link

configure.ac code for overlinking protection #68

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It's a good idea to use LDFLAGS="-Wl,--as-needed" when linking 
ffmpegthumbnailer to prevent overlinking to libraries inherited from e.g. 
FFmpeg.
This way when one of the indirect libs get upgraded, there won't be unnecessary 
NEEDED entry in ffmpegthumbnailer and you get a free-pass from recompiling the 
package.

The code is borrowed from thunar-volman-0.5.1's aclocal.m4 (xfce4 package). The 
flag is also enabled by default for packaging in several distros (Gentoo, 
Fedora, Debian ...).

Also this way you won't miss issues like for what 2.0.4 was released.

Original issue reported on code.google.com by ssuomi...@unk.fi on 7 Aug 2010 at 2:20

Attachments:

GoogleCodeExporter commented 9 years ago
Original code is here, it also adds -Wl,-O1 but I'm not sure if that's a good 
idea to enable in upstream packages... either way, it works for 
ffmpegthumbnailer well

Original comment by ssuomi...@unk.fi on 7 Aug 2010 at 2:22

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the information, the patch has been applied.

Original comment by dirk.vdb on 9 Aug 2010 at 4:57