google-code-export / ffmpegthumbnailer

Automatically exported from code.google.com/p/ffmpegthumbnailer
GNU General Public License v2.0
1 stars 1 forks source link

pngwriter.cpp uses voidp instead of png_voidp #79

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Build ffmpegthumbnailer in an environment without voidp defined.
2. Watch it break.

What is the expected output? What do you see instead?

libtool: compile:  c++ -DHAVE_CONFIG_H -I. 
-I/usr/pkgsrc/multimedia/ffmpegthumbnailer/work/.buildlink/include 
-I/usr/pkgsrc/multimedia/ffmpegthumbnailer/work/.buildlink/include/libpng15 
-D__STDC_CONSTANT_MACROS -MT libffmpegthumbnailer_la-pngwriter.lo -MD -MP -MF 
.deps/libffmpegthumbnailer_la-pngwriter.Tpo -c 
libffmpegthumbnailer/pngwriter.cpp  -fPIC -DPIC -o 
.libs/libffmpegthumbnailer_la-pngwriter.o
libffmpegthumbnailer/pngwriter.cpp: In constructor 
'ffmpegthumbnailer::PngWriter::PngWriter(std::vector<unsigned char, 
std::allocator<unsigned char> >&)':
libffmpegthumbnailer/pngwriter.cpp:52: error: 'voidp' was not declared in this 
scope
*** Error code 1

The libpng API provides png_voidp and expects that as the type to be passed as 
the second argument to png_set_write_fn().

Changing the cast to png_voidp instead of void to match the API solves the 
problem.

What version of the product are you using? On what operating system?

ffmpegthumbnailer 2.0.6 on NetBSD 4.0_BETA2.

Please provide any additional information below.

Original issue reported on code.google.com by gavanfan...@googlemail.com on 20 Jan 2011 at 8:49

GoogleCodeExporter commented 9 years ago
Fixed in subversion, thanks for the info!

Original comment by dirk.vdb on 25 Jan 2011 at 4:35