google-code-export / firephp

Automatically exported from code.google.com/p/firephp
1 stars 0 forks source link

FirePHP checks for 1.8 while claiming to require 1.5+ only #175

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What versions and operating system are you using?

OS: Linux
Firefox: 3.6
Firebug: 1.7.3
FirePHP Server Library: N/A
FirePHP Extension: 0.6.1

What is the problem?
Restarting the browser creates a notification "You need Firebug 1.5+ to use 
FirePHP!"

What steps will reproduce the problem?
1. Install Firefox 3.6
2. Install Firebug 1.7.3 (highest version supporting FF3.6)
3. Install FirePHP 

What is the expected output? What do you see instead?
A working FirePHP with no invalid notifications (the FirePHP code seems to be 
working though).

Please provide any additional information below.
The notification and the actual code are at odds, the notification is 
appendNotification("You need Firebug 1.5+ to use FirePHP!", but the code that 
gets there checks FIREBUG_MIN_VERSION which is set to 1.8, not 1.5.

If 1.8 is the actual required version, update the notification and also update 
the minimum Firefox version to 4.0

Original issue reported on code.google.com by mirrorki...@gmail.com on 15 Aug 2011 at 2:29

GoogleCodeExporter commented 9 years ago

Original comment by christ...@christophdorn.com on 15 Aug 2011 at 5:15

GoogleCodeExporter commented 9 years ago
I also get this problem when upgrading the firebug to 1.7.3 . even when I 
degrade firebug to 1.5, the problem still exits,so I open the Profile directory 
of firePHP, checkt he file of firephp.js ,Line 70:const FIREBUG_MIN_VERSION = 
"1.8"; Oh my god, then I have to modify it back to 1.5 and everything is OK 
now. 

Original comment by wonderfu...@gmail.com on 18 Aug 2011 at 3:22

GoogleCodeExporter commented 9 years ago
Please see: 
http://groups.google.com/group/firephp-dev/browse_thread/thread/869b20019b33db3c

Can you confirm that it works now if you download FirePHP 0.5.0 from 
http://www.firephp.org/ and use it with Firebug 1.7.3 and Firefox 3.6.

Interesting that 0.6.1 works with Firebug < 1.8 for you if you change the min 
version. I'll have to look into that more. Maybe we can use the latest release 
with all Firebug versions after all.

Original comment by christ...@christophdorn.com on 18 Aug 2011 at 4:23

GoogleCodeExporter commented 9 years ago

Original comment by christ...@christophdorn.com on 18 Aug 2011 at 4:24

GoogleCodeExporter commented 9 years ago

Original comment by christ...@christophdorn.com on 18 Aug 2011 at 4:24

GoogleCodeExporter commented 9 years ago

Original comment by christ...@christophdorn.com on 22 Aug 2011 at 6:44