Show indicate new not unread mails

[GoogleCodeExporter]

Currently Firetray shows all unread mails. That way it also counts mails like 
drafts which I saved. That makes the tray notification for new mails unclear.

Original issue reported on code.google.com by mene...@yahoo.de on 22 Jun 2010 at 10:21

[GoogleCodeExporter]

confirmed, firetray-0.2.6

Original comment by hicham.h...@gmail.com on 23 Jun 2010 at 12:10

[GoogleCodeExporter]

Original comment by fsoltr...@gmail.com on 13 Jul 2010 at 12:58

• Added labels: Type-Enhancement, Priority-Low
• Removed labels: Type-Defect, Priority-Medium

[GoogleCodeExporter]

The following patch fixes this for gmail ( at least )

Original comment by hicham.h...@gmail.com on 16 Jul 2010 at 6:41

Attachments:

• mozilla-firetray-0.2.8-fix-unread-mail-count.patch

[GoogleCodeExporter]

How is the patch installed?

Original comment by garfield...@gmail.com on 27 Jul 2010 at 9:37

[GoogleCodeExporter]

The patch hard-codes only counting folders called "Inbox".  This is not a 
suitable general fix for this problem, although it will be useful for many 
people.  New (or unread) mail can potentially appear in a folder with any name. 
 Ultimately the only general solution is to allow the user to choose folders to 
be watched.  Issue 105 makes a stab at this, but unfortunately it only 
specifies accounts to be watched and then counts messages in any folder of that 
account, including drafts, hence not fixing this exact problem.

I'll also address the related issue mentioned in several issues, and implicitly 
referred to here.  That is the difference between new and unread messages.  
Unread is very simple to define and implement, assuming we can decide which 
folders to count unread messages from.  New messages are different  It refers 
to messages which have arrived since the user last "observed" the messages, 
such as since the last time TB was closed.  Messages which were present at the 
previous "observation", even if they are still unread, are not considered to be 
new.  This is a very useful concept, as seen from the number of people 
requesting it, but it can be difficult to define precisely.  You can observe 
clients like Claws that count both new and unread, but they are simpler than 
Thunderbird.  Ideally there would be visibly different notifications for new 
and unread messages.

Patches are simple to apply using the patch command on almost any Linux, but 
you will first have to extract the core.js file from the firetray.jar file in 
your profile.  Once you have applied the patch, you will have to recreate the 
jar file (from the content and locale folders, not from the firetray folder!).  
The changes should appear the next time you start TB, but if not delete the 
*.mafsl files in your profile (I forget which of the two you actually need to 
delete, I think XUL.mafsl, but it is safe to delete both).

Original comment by goo...@nartowicz.co.uk on 21 Sep 2010 at 9:06

[GoogleCodeExporter]

I admit that this is not a robust approach, but how can we skip counting unread 
mail from trash, spam, and draft ? By doing the inverse, ie count anything but 
the undesired folders ?

Original comment by hicham.h...@gmail.com on 21 Sep 2010 at 9:35

[GoogleCodeExporter]

I can't imagine any solution other than letting the user choose.  Count spam 
folders or not?  Count spam in inboxes or not?  Count messages filtered to 
non-inbox folders or not?  Count drafts or not?  Even whether to count every 
inbox?

Original comment by goo...@nartowicz.co.uk on 25 Sep 2010 at 7:41

[GoogleCodeExporter]

Attached patch is a bit more robust version of the above as it uses the "Inbox" 
flag instead of the folder name and should theoretically work with TB2 (not 
sure if firetray supports it though)

It also adds an option to choose inbox only vs standard count. 

The patch is to the entire firetray.jar contents.  Unzip the file into a dir, 
apply patch, zip back up, replace the jar file.

Note, due to the new preference, this may not work for languages other than 
en_US until translations are added.

Original comment by mlasev...@gmail.com on 29 Sep 2010 at 7:26

Attachments:

• firetray.patch

[GoogleCodeExporter]

Sorry how do you apply the patch. I've done many searches and can't find a 
clear instruction as to what command to use. I've atempted it several times but 
nothing has worked. Can you explain what this 'simple' patch command is?

Original comment by amad...@gmail.com on 23 Oct 2010 at 6:44

[GoogleCodeExporter]

"patch -p1" will do the trick (at least for my patch)

Unzip your firetray.jar into an empty directory
In a shell, cd into that directory
run: "patch -p1 </path/to/firetray.patch"
(obviously replace "/path/to" with proper location for the patch file, can be 
relative)
Then re-zip the firetray.jar and replace the existing one with new version. 
Restart TB and check the add-in preferences for the new settings. 

HTH

Original comment by mlasev...@gmail.com on 23 Oct 2010 at 6:58

[GoogleCodeExporter]

Issue 137 has been merged into this issue.

Original comment by fsoltr...@gmail.com on 5 Jul 2011 at 10:00

[GoogleCodeExporter]

Original comment by fsoltr...@gmail.com on 5 Jul 2011 at 10:19

• Changed state: Done