google-code-export / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
2 stars 0 forks source link

javascript controlbar bugs, especially with replay #295

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I am copying the original post from this forum thread
http://flowplayer.org/forum/8/65200
which lists and describes the issues perfectly:

Bug 1:
The progressbar doesn't update smoothly, which I would expect from a 
progressbar for a video. This might not be a bug, but a technical limitation. 
If it is a technical limitation, then the only bug here, would be that it needs 
to be described on the plugin page.

Bug 2:
The progressbar doesn't always go to the end of the track, when the video is 
done. It seems that it can stop a few pixels from the end of the track, so it 
doesn't look as if it has reached the end. It seems to occur randomly and once 
in a while the progressbar actually reaches the end.

Bug 3:
Like Bug 2, the time does not reach the "end". if a videoclip is 25 seconds 
long, it will stop at 24, so it will show "00:24 / 00:25".

Bug 4:
When a clip have been played to the end, it seems that the progressbar is 
suddently detached from the video and if the user clicks "play again", the 
progressbar is not reset to the beginning of the video.
It is, oddly enough, still possible to click on the progressbar and skip to 
that part of the videoclip, but the progressbar doesn't move forward afterwards.

Bug 5:
Like Bug 4, The timer is not reset, when the user clicks "play again".

I have tested this in Firefox 4 and Internet Explorer 8, both giving same 
results. It is possible that other browsers will give different results, as I 
have not tested other browsers.

To reproduce it, you can watch the demo on the Javascript Control Plugin page 
here:http://flowplayer.org/plugins/javascript/controlbar.html 

Original issue reported on code.google.com by blacktrashproduct on 2 Jun 2011 at 2:12

GoogleCodeExporter commented 9 years ago
Bug 5 should be fixed with our current development player SWF.

Original comment by anssip@gmail.com on 20 Jun 2011 at 12:46

GoogleCodeExporter commented 9 years ago
changed the controlbar to update itself every 100 milliseconds instead of the 
old 500 millisecond: 
http://code.google.com/p/flowplayer-plugins/source/browse/javascript/controls/tr
unk/flowplayer.controls.js?r=1546

 As a reault the movement is much smoother now and bugs 1 - 3 are solved with this. Bugs 4 and 5 don't occur with the trunk version.

Original comment by anssip@gmail.com on 5 Jul 2011 at 1:08

GoogleCodeExporter commented 9 years ago
this is the diff for the fix: 
http://code.google.com/p/flowplayer-plugins/source/diff?spec=svn1599&r=1599&form
at=side&path=/javascript/controls/trunk/flowplayer.controls.js&old_path=/javascr
ipt/controls/trunk/flowplayer.controls.js&old=1546

Original comment by anssip@gmail.com on 5 Jul 2011 at 1:15

GoogleCodeExporter commented 9 years ago
Yes, looks good.

However, in this sample:
http://flowplayer.blacktrash.org/dev/issue295.html
with clip {autoPlay: false, autoBuffering: true} I would expect the 
duration/fullDuration to be present and evaluated after the clip starts 
buffering - because in theory this should not only have triggered onMetadata, 
but also onStart.

Original comment by blacktrashproduct on 6 Jul 2011 at 7:48

GoogleCodeExporter commented 9 years ago
Committed a new fix that makes it to show the duration when  {autoPlay: false, 
autoBuffering: true}

Original comment by anssip@gmail.com on 6 Jul 2011 at 8:58

GoogleCodeExporter commented 9 years ago
It does. Confirmed. Thank you.

Original comment by blacktrashproduct on 6 Jul 2011 at 9:44