search

google-code-export / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
2 stars 0 forks source link

Inline styling support for TTML captions #386

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1.TTML supports inline styling, so for example using different colors for 
certain words in a line of text. 
2.When adding such color change (tts:color) in the current captions plugin 
(within 'spans'), it keeps the color as set in the beginning of a line of text 
as 'style' while it should show a different color.
3.except color, this also applies to other style elements such as italic and 
bold.

What is the expected output? What do you see instead?
When this is implemented, you can see lines of subtitle texts (captions) with 
different colors or font styles within that text, or eg two lines of text 
seperated by a <br/> where the second line has a different color. 

What version of the product are you using? On what operating system?
flowplayer.captions-3.2.3. Both on windows XP and 7.

Please provide any additional information below.
I've attached an exmaple xml file showing inline color changes

Original issue reported on code.google.com by j.mooijw...@sempresole.eu on 19 Sep 2011 at 7:44

Attachments:

GoogleCodeExporter commented 9 years ago 
See also this forum thread:
http://flowplayer.org/forum/8/75443

Nesting styles which are declared in head has not effect either. Example:

<?xml version="1.0" encoding="utf-8"?>
<tt xml:lang="en" xmlns="http://www.w3.org/2006/10/ttaf1" 
xmlns:tts="http://www.w3.org/2006/10/ttaf1#styling" 
xmlns:ttp="http://www.w3.org/2006/10/ttaf1parameter" ttp:frameRate="25">
  <head>
    <styling>
      <style id="WhiteBold" tts:color="#FFFFFF" tts:fontFamily="Arial" tts:textAlign="center" tts:fontSize="18px" tts:fontWeight="bold" />
      <style id="GreenSpan" tts:color="#008000" />
    </styling>
  </head>
  <body>
    <div xml:lang="en">
      <p id="subtitle1" begin="00:00:00.00" end="00:00:02.00" style="WhiteBold">Demo<br/> Next word should be <span style="GreenSpan"> green </span></p>
    </div>
  </body>
</tt>

Original comment by blacktrashproduct on 19 Sep 2011 at 9:52

GoogleCodeExporter commented 9 years ago 
Ok this isn't a bug, but a feature required to support span styling within the 
div / p items. Style support is currently on p / div / body only. Will confirm 
what to do about this, you require to add styling support for <span 
style="GreenSpan">  and <span tts:color="#FFFFFF">

Original comment by dani...@electroteque.org on 21 Sep 2011 at 3:03

GoogleCodeExporter commented 9 years ago 
What is required is also known as referential styling so the example with <span 
style="GreenSpan">. There is no need to add inline styling like <span 
tts:color="#FFFFFF"> because these will be predefined in the Syling section.

Original comment by j.mooijw...@sempresole.eu on 22 Sep 2011 at 9:37

GoogleCodeExporter commented 9 years ago 
Well, the docs are not very explicit about what is supported. They just say 
that referential styling is supported (which I immediately recommended to the 
user, only to find out it does not work for spans, indeed creating a span also 
removes the preceding space), but nothing about certain tags which are not. If 
you turn to the content plugin for clarity, it says that the span tag is 
supported.

So: are we going to support spans? Or say in the docs that spans are not 
supported?

Original comment by blacktrashproduct on 22 Sep 2011 at 10:25

GoogleCodeExporter commented 9 years ago 
They need to be parsed out and normalised to class or style attributes, there 
is some work there, this does not support inline span inside the content for 
the moment, I have to confirm if its ok to support it as its a feature request. 

You will find in the documentation the styling example on the p tags, it can 
also be on the div and body tag. There is no reference there to inline span 
tags so obviously not supported.  

There is also only so much that can be supported from the spec anyway but most 
is there.

Original comment by dani...@electroteque.org on 22 Sep 2011 at 11:17

GoogleCodeExporter commented 9 years ago 
TTML supports both inline styling as well as referential styling and spans.

If you want to display subtitles, you do need both spans (and linebreaks
/br) and a way to use multiple styles in one subtitle. For the latter I
prefer referential styling.

We are currently setting up the definitions of a European Wide subtitle spec
(issued by the Swiss EBU) which is based on TTML. 
This will support referential styling and spans, so to keep the flowplayer's
caption plugin compliant to international standards, adding this would
assure it is compliant.

We found these styling issues when testing some latest EBU specs.

Thx

Jan 

-----Oorspronkelijk bericht-----
Van: flowplayer-core@googlecode.com [mailto:flowplayer-core@googlecode.com] 
Verzonden: donderdag 22 september 2011 12:26
Aan: j.mooijweer@sempresole.eu
Onderwerp: Re: Issue 386 in flowplayer-core: Inline styling support for TTML
captions

Original comment by j.mooijw...@sempresole.eu on 22 Sep 2011 at 11:32

GoogleCodeExporter commented 9 years ago 
I can fix this partially until I get the ok for the others. it should be 
parsing the span but a portion of the code is removing them completely from 
being parsed because of the namspaces so once the span tags are in the content 
it should become something like this should work but its not the ttxt standard 
yet :)

<span class="WhiteBold">This this the second line in white</span>

Original comment by dani...@electroteque.org on 22 Sep 2011 at 11:41

GoogleCodeExporter commented 9 years ago 
A question from my side.

Currently the following example works except the effect of the styling in
the second line of text. So it will display all text correctly but the 2nd
style has no effect (all text will be WhiteBold):

<styling>
  <style id="WhiteBold" tts:color="#FFFFFF" tts:fontFamily="Arial"
tts:fontSize="18px" tts:fontStyle="Bold" /> 
  <style id="Yellow" tts:color="#FFFF00" tts:fontFamily="Arial"
tts:fontSize="18px" /> 
  <style id="Aqua" tts:color="#00FFFF" tts:fontFamily="Arial"
tts:fontSize="18px" /> 
  <style id="White" tts:color="#FFFFFF" tts:fontFamily="Arial"
tts:fontSize="18px" /> 
</styling>

<body>
  <p id="subtitle1" begin="00:00:00.000" end="00:00:04.000"
style="WhiteBold"> First line of text. <br/> 
    <span style="White">Second line of text.</span> 
  </p>
</body>

In your example you use class=  instead of style= for the 2nd line. Is that
because using class= is easy to fix?

Thx

Jan

-----Oorspronkelijk bericht-----
Van: flowplayer-core@googlecode.com [mailto:flowplayer-core@googlecode.com] 
Verzonden: donderdag 22 september 2011 13:42
Aan: j.mooijweer@sempresole.eu
Onderwerp: Re: Issue 386 in flowplayer-core: Inline styling support for TTML
captions

Original comment by j.mooijw...@sempresole.eu on 22 Sep 2011 at 12:09

GoogleCodeExporter commented 9 years ago 
No looks like to add span tags in, its halfway to fully supporting all options. 
Currently will only return the text elements and not the tags , have to confirm 
as its a feature requirement.

Original comment by dani...@electroteque.org on 22 Sep 2011 at 1:37

GoogleCodeExporter commented 9 years ago 
Hi, the inline span tags are not supported currently, there may be no plans to 
support this however and there may be a javascript plugin version available in 
the future.

 Sorry about that. 

I will close this for now.

Original comment by dani...@electroteque.org on 26 Sep 2011 at 5:05

GoogleCodeExporter commented 9 years ago 
That would mean that flowplayer will not be suitable for displaying subtitles. 

Missed opportunity. We have to look into other players.

Jan

Op 26 sep. 2011 om 19:05 heeft flowplayer-core@googlecode.com het volgende 
geschreven:

Original comment by j.mooijw...@sempresole.eu on 26 Sep 2011 at 9:26

GoogleCodeExporter commented 9 years ago 
Hi, I'm reopening again with the possibility of adding in, after the release of 
Flowplayer 3.3. It's trivial to support custom style tags but for now there is 
only the said options to add style information to. 

To be honest most subtitling is in the one colour, and the sub titling 
functions fine.

Original comment by dani...@electroteque.org on 27 Sep 2011 at 1:39

GoogleCodeExporter commented 9 years ago 
Thank you,

There are basically two types of subtitles, one for translated subs, indeed in 
one color, and for the hard of hearing people in multiple colors. Besides that 
other styling items are, or will be used like bold, italics etc. 
But most important at this moment are the colors and the ability to use 
multiple colors in one subtitle block.

If you have any question about this or need some example files please let me 
know.

Thank you.

Jan

Op 27 sep. 2011 om 15:40 heeft flowplayer-core@googlecode.com het volgende 
geschreven:

Original comment by j.mooijw...@sempresole.eu on 27 Sep 2011 at 9:48