google-code-export / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
2 stars 0 forks source link

controlbar: autoHide: {enabled: true} has no effect #485

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Once you try to set autoHide properties in the autoHide object autoHiding 
becomes disabled, even when you explicitly specify:

plugins: {
  controls: {
    autoHide: {
      // stuff like hideDelay
      enabled: true // has no effect (should also be the default)
    }
  }
}

Bug present both in 3.2.8 dev Build time: March 01 2012 05:57 PM GMT and 3.2.7.

Original issue reported on code.google.com by blacktrashproduct on 8 Mar 2012 at 9:38

GoogleCodeExporter commented 9 years ago
Also please someone actually check whether hideDelay then has an effect at all. 
I cannot get it to work with the probably invalid:

plugins: {
  controls: {
    hideDelay: 10000 // should probably be in the autoHide object
  }
}

So the autoHide properties _must_ be configured properly in the autoHide 
object, but once you start configuring an autoHide object, auto hiding becomes 
disabled, which obviously defeats the whole purpose.

Original comment by blacktrashproduct on 8 Mar 2012 at 9:47

GoogleCodeExporter commented 9 years ago
enabled config is handled correctly but the default state is hide in fullscreen 
instead of always for some reason. 

Original comment by dani...@electroteque.org on 9 Mar 2012 at 2:22

GoogleCodeExporter commented 9 years ago
Here is the issue, for some reason fullscreen state is enabled by default. 

controls config does not append and override the autohide config, it replaces 
it, therefore fullscreen state is left on and you are required to set state: 
"always" . Its most likely doing these things for other configs so will fix it 
here rather than the autohide config itself. 

Original comment by dani...@electroteque.org on 9 Mar 2012 at 3:06

GoogleCodeExporter commented 9 years ago
Fixed in trunk. This was a painful one, the properties are seriously 
convoluted. what ive done is initialised the autohide config with 
fullscreenOnly disabled as its enabled by default and more logical this way. So 
to turn on auto hide for fullscreen only simply set fullscreenOnly: true. 

Original comment by dani...@electroteque.org on 9 Mar 2012 at 9:27

GoogleCodeExporter commented 9 years ago
Not really, see issue583

Original comment by blacktrashproduct on 2 Jun 2012 at 9:15