google-code-export / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
2 stars 0 forks source link

api: addCuepoint does nothing #518

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.
$f().getClip().addCuepoint([5000]);
or
$f().getClip().addCuepoint([[5000], function () {
  $f().pause();
}]);
which seems problematic as only one cuepoint handler can be configured
or
$f().addCuepoint([5000]);
or
$f().addCuepoint([[5000], function () {
  $f().pause();
}]);

What is the expected output? What do you see instead?
Expected: a cuepoint is added
Instead: nothing happens

addCuepoint is not *listed* in our api documentation, but it is *mentioned* for 
the clip.cuepoints property here:
http://flowplayer.org/documentation/api/clip.html#properties

"The cuepoint objects of this clip. The property contains all embedded 
cuepoints, cuepoints specified in the configuration and also all cuepoints 
added dynamically using the addCuepoint() method."

It can also be found here:
http://releases.flowplayer.org/apidoc-latest/org/flowplayer/model/Clip.html#addC
uepoint%28%29
in conjunction with addCuepoints

Is this really a public function? Or do the docs actually refer to the 
onCuepoint API call:
$f().onCuepoint([5000], function () {
  $f().pause();
});

?? Please clarify.

Original issue reported on code.google.com by blacktrashproduct on 18 Apr 2012 at 1:08

GoogleCodeExporter commented 9 years ago
See also issue519.

Original comment by blacktrashproduct on 18 Apr 2012 at 1:38

GoogleCodeExporter commented 9 years ago
If I read flowplayer.js correctly addCuepoint is only an internal method called 
like this:
player._api().fp_addCuepoints(points, index, fnId);

Will therefore replace addCuepoint with onCuepoint in the docs. Which still 
leaves issue519.

Original comment by blacktrashproduct on 22 Apr 2012 at 8:49

GoogleCodeExporter commented 9 years ago
Closing, will fix in docs.

Original comment by blacktrashproduct on 22 Apr 2012 at 8:50