Link to download flash doesn't work when using div as container

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Set up flowplayer, using a div as root container
2. Disable flash
3. We see "Flash version 9,0 or greater is required. You have no flash plugin 
installed. Download latest version from here", however the link doesn't work

An example can be seen on flowplayer's own documentation page at 
http://flowplayer.org/documentation/events/index.html

The container window is catching the click, and re-rendering the html and 
preventing event propagation.

I've create a fix at 
https://github.com/mtibben/flowplayer/commit/14af2dc2f01246d6aa437a56d94cb2efcfe
9e9fb

Original issue reported on code.google.com by michael....@99designs.com on 24 Apr 2012 at 6:42

[GoogleCodeExporter]

Hi thanks, its a little simpler than that, merely needs to check if its a div 
container also. 

http://dl.dropbox.com/u/3394987/flowplayer-3.2.9.min.js

Please try this build. 

Original comment by dani...@electroteque.org on 24 Apr 2012 at 12:21

[GoogleCodeExporter]

No, that doesn't work

Original comment by michael....@99designs.com on 25 Apr 2012 at 11:18

[GoogleCodeExporter]

Correction: This works in IE, firefox and safari, but does not work in Chrome. 

I actually tried that originally, however as I'm testing in Chrome it didn't 
work so I decided that the best way was to remove events from the element. 
However this is difficult due to the location of the doClick function, so 
cloning seemed the best option to duplicate the element without events. However 
my patch doesn't seem to work work in IE.

Any further ideas ?

Original comment by michael....@99designs.com on 26 Apr 2012 at 12:03

[GoogleCodeExporter]

What is the purpose of the stopEvent ?  Can't we just let the event propagate ?

Original comment by michael....@99designs.com on 26 Apr 2012 at 12:04

[GoogleCodeExporter]

i've updated my patch to use both solutions 
https://github.com/mtibben/flowplayer/commit/8f3f3367b1bab7c982f6b72c454496f4c2f
f1ba0

Original comment by michael....@99designs.com on 26 Apr 2012 at 12:50

[GoogleCodeExporter]

full patch at 
https://github.com/mtibben/flowplayer/compare/612e2f557ba884b7ae21f46943489ae73e
0f2f85...8f3f3367b1bab7c982f6b72c454496f4c2ff1ba0

Original comment by michael....@99designs.com on 26 Apr 2012 at 1:59

[GoogleCodeExporter]

Hi tested on chrome in windows 7 and location.href works fine. 

Original comment by dani...@electroteque.org on 26 Apr 2012 at 6:39

[GoogleCodeExporter]

I cannot replicate any issue if the check for div is applied, therefore this is 
fixed and will close for now thanks. 

Original comment by electrot...@gmail.com on 1 May 2012 at 4:26

• Changed state: Fixed

[GoogleCodeExporter]

Still fails with A tag containers, see issue588

Original comment by blacktrashproduct on 7 Jun 2012 at 11:31