google-code-export / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
2 stars 0 forks source link

cuepoints should not be rounded to 100 milliseconds #533

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. a cuepoint at 140 will be rounded to 100
2. http://flowplayer.org/documentation/api/clip.html#properties
says:
The times of embedded cuepoints are multiplied by this value before being used. 
Some encoding tools embed cuepoints in seconds but Flowplayer processes 
cuepoints in milliseconds. Note that the times are also rounded to the nearest 
100 milliseconds. For example, if a file has a cuepoint at 5.535 seconds, the 
cuepoint is fired at 5500 milliseconds (assuming the default multiplier value 
of 1000).

Is there any technical reason why this is needed? Precise cuepoints are needed 
e.g. in online tutorials. Right now you cannot set a cuepoint with frame 
precision.

Original issue reported on code.google.com by blacktrashproduct on 2 May 2012 at 5:55

GoogleCodeExporter commented 9 years ago
See: http://flowplayer.org/forum/support.html?id=99226

Original comment by blacktrashproduct on 2 May 2012 at 5:56

GoogleCodeExporter commented 9 years ago
correct, it is rounding in the playtimetracker, the interval for the checks is 
in the progress timer which is 30ms which is the likely reason for this, so its 
within the 100ms range. making the interval 1ms may cause serious performance 
issues and the particular code in here and bubbling down may need a heap of 
fine tuning, ie not using math libraries for the rounding ie casting to int is 
faster etc. 

Original comment by electrot...@gmail.com on 2 May 2012 at 3:09

GoogleCodeExporter commented 9 years ago
If it would mean a serious performance hit, then let's not touch it. That's 
definitely a good reason to leave it as it is. I just wanted to know.

The finest grain would not be 1ms anyway, but at least 10ms - you don't want to 
broadcast movies with 1000fps ;-) - on the other hand if someone has left the 
video at an ntsc framerate of 30000/1001 even 1ms would miss frames.

Closing this one, reopen if struck by genius ;-)

Original comment by blacktrashproduct on 2 May 2012 at 3:44

GoogleCodeExporter commented 9 years ago
I can look further if needed thats just an observation of the interval it picks 
up the cuepoints, it might not be entirely true and pick up the closest time if 
it just past that point when not rounded.  

Original comment by electrot...@gmail.com on 5 May 2012 at 11:32