google-code-export / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
2 stars 0 forks source link

caption button's fontSize cannot be styled #546

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.
plugins: {
  captions: {
    url: 'flowplayer.captions-3.2.8.swf',
    captionTarget: 'content',
    button: {
      height: 34,
      width: 72,
      fontSize: 30
    }
  },
  content: {url: 'flowplayer.content-3.2.8.swf'}
}

What is the expected output? What do you see instead?
Expected: fontSize can be set
Instead: setting fontSize has no effect, also not within a style object

If we allow the display properties of the button to be set it can be argued 
that the fontSize should be configurable as well - why else would I want to 
change the size of the plugin for instance.

Original issue reported on code.google.com by blacktrashproduct on 9 May 2012 at 5:41

GoogleCodeExporter commented 9 years ago
See also: http://flowplayer.org/forum/5/99866

Original comment by blacktrashproduct on 9 May 2012 at 5:44

GoogleCodeExporter commented 9 years ago
I agree. It's nice to be able to set a custom size for the button, but the text 
stays small and top-right aligned. It would be nice to set a custom font size 
for the button. The video player I'm using is large, and I want the "CC" button 
to be more visible. Changing the size of the button seems pointless if I can't 
change the size/alignment of the text within it.

Original comment by dbhy...@gmail.com on 9 May 2012 at 7:02

GoogleCodeExporter commented 9 years ago
Its a legacy implementtion, it should perhaps be a toggle button and added to 
the dock like the other buttons, and sized accordingly is that the idea ? 

Original comment by electrot...@gmail.com on 10 May 2012 at 11:56

GoogleCodeExporter commented 9 years ago
Yeah, makes sense to ditch the extra interface for this button and integrate it 
with the dock.

Original comment by blacktrashproduct on 11 May 2012 at 12:21

GoogleCodeExporter commented 9 years ago
That works for me.

Original comment by dbhy...@gmail.com on 11 May 2012 at 3:55