3.2.12: controls.autoHide: 'always' behaves like autoHide: 'never' (regression)

[GoogleCodeExporter]

What steps will reproduce the problem?
1. flowplayer-3.2.12.swf and
2.
plugins: {
  controls: {
    autoHide: 'always'
  }
}

What is the expected output? What do you see instead?

Expected: autoHide of controlbar always enabled
Instead: autoHide of controlbar completely disabled

Does not happen in 3.2.11

Obviously a (further) regression caused by the work on issue583.

Original issue reported on code.google.com by blacktrashproduct on 3 Jul 2012 at 8:06

[GoogleCodeExporter]

See also: http://flowplayer.org/forum/2/101661

Original comment by blacktrashproduct on 3 Jul 2012 at 8:09

[GoogleCodeExporter]

yep it's still a mess because of this requirement of the fullscreenonly 
property to be true to reposition the screen correctly so therefore there is a 
bit in there to return fullscreen as the state if the property is true geez. 

Original comment by dani...@electroteque.org on 4 Jul 2012 at 1:28

[GoogleCodeExporter]

https://dl.dropbox.com/u/3394987/flowplayer.controls-3.2.11.zip

Please try this the change occurs directly in the autohide config, it will set 
the fullscreen property if the state is not always which logically works fine 
for everything. tested again the many different ways to config it, screen 
positions fine still. 

Original comment by dani...@electroteque.org on 4 Jul 2012 at 1:46

[GoogleCodeExporter]

hopefully no more surprises 

Original comment by dani...@electroteque.org on 4 Jul 2012 at 1:18

[GoogleCodeExporter]

push a new release I think, need to possible run a quick update for this no new 
version I reckon, controls / viralvideos / sharing. It also seems the menu 
plugin has not been updated due to the changes to the accessibility options. 

Original comment by dani...@electroteque.org on 6 Jul 2012 at 4:51

[GoogleCodeExporter]

Please also test it with the adsense plugin:
http://flowplayer.org/plugins/advertising/adsense/index.html
because in that case even the default behaviour does not work (again see the 
forum thread)
and/or notify the advertising plugin developers because advertising plugins 
nearly always access the controlbar (to disable widgets etc.).

Original comment by blacktrashproduct on 6 Jul 2012 at 5:31

[GoogleCodeExporter]

np ill test accessing the controlbar plugin method to change autohide also. 

Original comment by dani...@electroteque.org on 7 Jul 2012 at 7:29

• Added labels: npi

[GoogleCodeExporter]

According to
http://flowplayer.org/forum/2/101661#post-101784
https://dl.dropbox.com/u/3394987/flowplayer.controls-3.2.11.zip
does not fix the issue - at least in connection with adsense.

Original comment by blacktrashproduct on 7 Jul 2012 at 12:30

[GoogleCodeExporter]

well the whole point of the exercise was the fix the pesky screen positioning 
issue, i'm not sure what adsense is doing internally but I have to ask jonas. 
again when i have a moment i will test the external method to control autohide 
which is likely what its doing. 

Original comment by dani...@electroteque.org on 7 Jul 2012 at 1:01

[GoogleCodeExporter]

$f("player").getPlugin('controls').setAutoHide({ state: "always"});  this works 
fine. will need the source code to the plugin to see whats going on. 

Original comment by dani...@electroteque.org on 7 Jul 2012 at 4:47

[GoogleCodeExporter]

I'll get onto them later today to get access to a copy of the plugin to 
properly test ;)

Original comment by dani...@electroteque.org on 9 Jul 2012 at 4:54

[GoogleCodeExporter]

confirmed this code which is the same as in the plugin is working

$("#always").click(function() {
console.log("original config:", config);
     $f("player").getPlugin('controls').setAutoHide(config);   
});

$("#never").click(function() {
    config = $f("player").getPlugin('controls').getAutoHide();
console.log(config);
     $f("player").getPlugin('controls').setAutoHide({ state: "never"});   
});

it is resetting to the original config above and autohides correctly. 

Original comment by dani...@electroteque.org on 9 Jul 2012 at 10:40

[GoogleCodeExporter]

perhaps push the new changes and it should work. 

Original comment by dani...@electroteque.org on 9 Jul 2012 at 10:40

[GoogleCodeExporter]

looks like its not related to these changes, but a referencing issue to the 
original config object. 

Original comment by dani...@electroteque.org on 9 Jul 2012 at 11:58

[GoogleCodeExporter]

ok finally this is working properly now, it was because fullscreenonly is 
enabled by default in the config which directly affects the state returned when 
setting and then re-setting the config and cloning the config. 

Went back and tested the screen issue with all config variations and works 
properly. 

Original comment by dani...@electroteque.org on 9 Jul 2012 at 2:37

[GoogleCodeExporter]

for some strange unknown reason the state property is not returned on the 
javascript config or else it would trigger the same issue as as3. 

Original comment by dani...@electroteque.org on 9 Jul 2012 at 2:41

[GoogleCodeExporter]

https://dl.dropbox.com/u/3394987/flowplayer.controls-3.2.12.zip

Original comment by dani...@electroteque.org on 9 Jul 2012 at 4:37

[GoogleCodeExporter]

Just tried the latest version on my page here 
http://www.top-windows-tutorials.com/windows-7-tutorial.html - Still not 
auto-hiding :(

Original comment by matthewa...@googlemail.com on 10 Jul 2012 at 8:49

[GoogleCodeExporter]

browser cache ;)

Original comment by dani...@electroteque.org on 11 Jul 2012 at 2:18

[GoogleCodeExporter]

Nope, cleared entire browser cache, tried again, still does not auto hide. 
Tried Firefox 13.0.1 and IE9.0.8112.16421 on two different machines. Not fixed 
I'm afraid.

Original comment by matthewa...@googlemail.com on 11 Jul 2012 at 9:35

[GoogleCodeExporter]

OK I will provide a screencast video as its working for me on your page. 

Original comment by dani...@electroteque.org on 11 Jul 2012 at 10:13

[GoogleCodeExporter]

your adsense plugin is throwing errors, disable that and see if that helps. 

Original comment by dani...@electroteque.org on 11 Jul 2012 at 10:15

[GoogleCodeExporter]

another fix in that came about with the dfp plugin when the controls is 
originally disabled there was a code bug there. 

Original comment by dani...@electroteque.org on 11 Jul 2012 at 3:23

[GoogleCodeExporter]

ok i see the issue, its to do with adsense, the original settings are not 
updating correctly and they have provided a fix for this, 

please try this

http://bigsool.com/adsense/downloads/bigsool.adsense-2.0.swf

Original comment by dani...@electroteque.org on 11 Jul 2012 at 3:39

[GoogleCodeExporter]

Ah thanks, sorry I've been a little ill over the past few days, just came to 
report that it was the Adsense plugin, disabling the plugin does cure the 
problem. I tried the fixed adsense swf but it's still not auto hiding, sorry.

Original comment by matthewa...@googlemail.com on 12 Jul 2012 at 6:26

[GoogleCodeExporter]

They say they know you. Are you able to contact them directly ? I've tested the 
same code they are using myself and it does reset back to normal settings. The 
issue is it's not resetting back to normal settings because it's referencing 
the changed settings ie "state: never"  and from the looks of it was always 
doing that. 

Original comment by dani...@electroteque.org on 13 Jul 2012 at 3:14

[GoogleCodeExporter]

Bigsool? Yes I've contacted them before they are pretty helpful, I'll pop a 
e-mail off to my contact at Bigsool referencing this issue.

Original comment by matthewa...@googlemail.com on 13 Jul 2012 at 1:54

[GoogleCodeExporter]

Yes they already know about it no problems. 

Original comment by electrot...@gmail.com on 13 Jul 2012 at 2:19

[GoogleCodeExporter]

Did they fix your problems with this ? Shall we close this now ? 

Original comment by electrot...@gmail.com on 24 Jul 2012 at 5:09

[GoogleCodeExporter]

All good with the auto hide now ?

Original comment by electrot...@gmail.com on 10 Aug 2012 at 11:41

[GoogleCodeExporter]

From my perspective, yes.

Original comment by blacktrashproduct on 10 Aug 2012 at 12:11

[GoogleCodeExporter]

closing for now thanks. 

Original comment by electrot...@gmail.com on 14 Aug 2012 at 10:06

• Changed state: Fixed