google-code-export / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
2 stars 0 forks source link

slowmotion: controlbar buttons must be clicked twice after 1st speed change #621

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. http://flowplayer.org/demos/plugins/streaming/slowmotion-fms.html
2. http://flowplayer.org/demos/plugins/streaming/slowmotion.html
3. play around with the controlbar speed buttons

What is the expected output? What do you see instead?
Expected: they work as the scripted html buttons
Instead: if you are in slomo/fastforward they reset to normal - even though the 
tooltips do not say so.

As we have no normal speed button (pausing seems to reset to normal - that's 
ok) either:
a) introduce a normal speed button (ugh, another button)
or
b) update tooltips to say "normal" when in slomo or ff

I smell controlbar danger here ;-) but as it stands the user interface is 
rather confusing, simply because the buttons do not always what the tooltips 
say.

Original issue reported on code.google.com by blacktrashproduct on 11 Aug 2012 at 9:56

GoogleCodeExporter commented 9 years ago
If you mouse up it returns to normal as there is no way to return to normal 
mode and causes chaos and crashes running into the buffer if left in that state 
in ff mode greater than x2. What is the expected outcome leave it running ? i 
made the change with the fixes. 

Original comment by electrot...@gmail.com on 11 Aug 2012 at 12:53

GoogleCodeExporter commented 9 years ago
the normal notification displays once mouse up. 

Original comment by electrot...@gmail.com on 11 Aug 2012 at 12:54

GoogleCodeExporter commented 9 years ago
I was talking about the _tooltips_, not about the notification:

1) Click on FastForword -> movie goes ff
2) Hover over ff button: says ff (I expect ff when clicking on it) - or any 
other ff or slomo button: they say clicking on them goes ot ff or slomo 
respectively
3) Click on ff again (or on any other ff or slomo button) -> movie goes normal 
(does not stay on ff or slomo as the tooltips say)

Original comment by blacktrashproduct on 12 Aug 2012 at 11:57

GoogleCodeExporter commented 9 years ago
skype on mon if possible, I don't see the issue or understand what the problem 
is sorry. The tooltips display on mouse over thats part of the widget design, 
there is no function to display a different tooltip apart from the toggle 
buttons. 

Original comment by electrot...@gmail.com on 12 Aug 2012 at 12:59

GoogleCodeExporter commented 9 years ago
What do you expect a button which says "FastForward" to do after you click on 
it?

I expect the button to fast forward.

But if I am not in normal playback mode, the button does NOT fast forward, it 
resets to normal mode.

I simply expect a button to do what it says it does.

The buttons only do what they advertise when the player is in normal playback 
mode.

Once we make the buttons behave like they advertise themselves, we need an 
extra button to go back to normal mode.

Original comment by blacktrashproduct on 12 Aug 2012 at 2:35

GoogleCodeExporter commented 9 years ago
Skype. The functionality is you press down, fast forwarded, mouse up normal as 
above and displays normal in the notification. What are you seeing ?

Original comment by electrot...@gmail.com on 13 Aug 2012 at 5:35

GoogleCodeExporter commented 9 years ago
I think I possibly answered it, lets see whats the issue first, but they could 
perhaps all become toggle buttons, so click for on, click again for normal.  I 
think on demand for FMS at the very least is a safe solution because it 
functions worse than wowza. 

Original comment by electrot...@gmail.com on 13 Aug 2012 at 8:01

GoogleCodeExporter commented 9 years ago
Ah, that's the problem: you press, I click ;-)

What I'm describing happens when you _click_ on the buttons - never had the 
idea to leave my mouse there.

Yes, seems to work with mousedown and up, but:

a) Clicking works as well, but on a toggle basis - which is inconsistent with 
the state messages and tooltip display
b) I am living proof that the mousedown/up approach is not obvious ;-)

Original comment by blacktrashproduct on 15 Aug 2012 at 11:38

GoogleCodeExporter commented 9 years ago
skype

Original comment by electrot...@gmail.com on 15 Aug 2012 at 1:10

GoogleCodeExporter commented 9 years ago
We'll make these toggle buttons with a toggle colour and normal tooltips on 
toggle state. 

Original comment by electrot...@gmail.com on 21 Aug 2012 at 1:10

GoogleCodeExporter commented 9 years ago
Originally these buttons worked like this:

1 click -> 2x speed
2nd click -> 4x speed
3rd click -> 8x xpeed
4th click -> back to normal

Has this changed now? This is how it should be in my opinion.

Original comment by anssip@gmail.com on 22 Aug 2012 at 8:27

GoogleCodeExporter commented 9 years ago
Ermh, we have 2 buttons for forward and backwards each. Slow and Fast Forward. 
Slow and Fast Backward. Your example seems to assume there is only _1_ button 
for Forward and Backward each.

Was it originally only 2 speed buttons?

Original comment by blacktrashproduct on 22 Aug 2012 at 9:38

GoogleCodeExporter commented 9 years ago
I'm sorry this was not obvious enough, I will move it back if need be.  

I can see that there, a more noticable toggle button is what had been discussed 
though there was no way to cancel out of these modes and because of some 
instabilitiy with fast forwarding into the buffers causes crashes.

Original comment by electrot...@gmail.com on 22 Aug 2012 at 9:55

GoogleCodeExporter commented 9 years ago
it just needs the mouseup state disabled to bring that functionality back in, 
please test if this is suitable

https://dl.dropbox.com/u/3394987/flowplayer.slowmotion-3.2.8.zip

It needs 3 clicks to come back to normal, the tooltips stay the same though 
which is why I suggested the possibility of toggle buttons to change the 
tooltips. 

Original comment by electrot...@gmail.com on 22 Aug 2012 at 10:03

GoogleCodeExporter commented 9 years ago
Perhaps update documentation if needed, and people need to display some tooltip 
on how to use the controls perhaps ? 

Original comment by electrot...@gmail.com on 22 Aug 2012 at 10:13

GoogleCodeExporter commented 9 years ago
I've committed it back.

Original comment by electrot...@gmail.com on 22 Aug 2012 at 10:16