google-code-export / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
2 stars 0 forks source link

setAutoHide stops working after being called once with css() call afterwards #624

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. This works: 
$f().getControls().setAutoHide({enabled: false})
                  .css({opacity: 0.5});
2. This does not:
$f().getControls().setAutoHide({enabled: false})
                  .css({opacity: 0.5})
                  .setAutoHide({enabled: true});
3. Also does not work without chaining or with a timeout.

What is the expected output? What do you see instead?
Expected: a way to set opacity on runtime for an autohiding controlbar
Instead: Execution stops after the css call. Also calling setAutoHide({enabled: 
true}) lateron after the css() call has no effect anymore.

We've made good headway with this in issue605, but this might be related to 
issue620 - which is rather terse in its description.

Original issue reported on code.google.com by blacktrashproduct on 18 Aug 2012 at 7:10

GoogleCodeExporter commented 9 years ago
My opinion it is still animating while the second call is being made will look 
at this. 

Original comment by electrot...@gmail.com on 20 Aug 2012 at 5:42

GoogleCodeExporter commented 9 years ago
I do see a problem but autoHide is functioning correctly. I can't get it to set 
opacity correctly although it's being called :o

Original comment by electrot...@gmail.com on 20 Aug 2012 at 10:53

GoogleCodeExporter commented 9 years ago
opacity has no effect for me,  i've never used that property personally, always 
the rgba values of the background colour to set its alpha setting. 

$f().getControls().css({backgroundColor: "rgba(18,52,86, 0.5)", 
backgroundGradient: "none" });

this works for me, i'll test with autohide. 

Original comment by electrot...@gmail.com on 20 Aug 2012 at 11:03

GoogleCodeExporter commented 9 years ago
This works

$f().getControls().setAutoHide({enabled: false})
                  .css({backgroundColor: "rgba(18,52,86, 0.5)", backgroundGradient: "none" })
                  .setAutoHide({enabled: true});

please confirm if opacity was ever working, im sure about that one. it is a 
styleable sprite so theoretically should be taking the setting. 

Original comment by electrot...@gmail.com on 20 Aug 2012 at 11:05

GoogleCodeExporter commented 9 years ago
The autohide feature is changing the opacity setting, if its disabled opacity 
displays, though still this affects all widgets. 

Original comment by electrot...@gmail.com on 20 Aug 2012 at 12:09

GoogleCodeExporter commented 9 years ago
unfortunately its a regression due to a fix to the autohide which causes 
performance issues / video dropped frames. Will have to first check if an 
opacity setting is used and use a different fading method compared to 
fadeIn/fadeOut which is the faster method. 

Original comment by electrot...@gmail.com on 20 Aug 2012 at 12:19

GoogleCodeExporter commented 9 years ago
that was fixed on the 6th of this month it seems, i'll test again :)

Original comment by electrot...@gmail.com on 20 Aug 2012 at 12:24

GoogleCodeExporter commented 9 years ago
its reverting back to its set original alpha setting when autohide displays not 
the new one because it doesn't know about it. not easy to fix. 

Original comment by electrot...@gmail.com on 20 Aug 2012 at 2:12

GoogleCodeExporter commented 9 years ago
Please try this

https://dl.dropbox.com/u/3394987/flowplayer.controls-3.2.13.zip

A new method was required to manually update the original display properties to 
return back to it when autohiding. Because autohide also manipulates the alpha 
setting, the update is only required when there is a alpha / opacity setting on 
the config to css or else it updates to an alpha of 0 :) Please give it a test 
and let me know. 

Original comment by electrot...@gmail.com on 20 Aug 2012 at 2:46

GoogleCodeExporter commented 9 years ago
Let me know if you have had a change to look at this. 

Original comment by electrot...@gmail.com on 3 Sep 2012 at 9:58

GoogleCodeExporter commented 9 years ago
this has been committed so considering it fixed. 

Original comment by electrot...@gmail.com on 4 Sep 2012 at 10:49