google-code-export / flowplayer-core

Automatically exported from code.google.com/p/flowplayer-core
2 stars 0 forks source link

seeking in fullscreen with stagevideo causes the previous frame to appear briefly. #627

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

No, it's independent of the protocol. See:
http://flowplayer.blacktrash.org/test/accel.html

1. go into fullscreen mode
2. move the playhead
3. picture flickers (jumps left and right)

Reopening.

see: http://code.google.com/p/flowplayer-core/issues/detail?id=503
http://code.google.com/p/flowplayer-core/issues/detail?id=612

Original issue reported on code.google.com by electrot...@gmail.com on 20 Aug 2012 at 5:07

GoogleCodeExporter commented 9 years ago
It's this screen mask which is required to show the canvas area it's 
repositioning itself on each seek as it obtains its coordinates from the 
stagevideo region. I'm not sure if it needs to keep checking for stagevideo 
state all the time just once and when going in and out of fullscreen. 

Original comment by electrot...@gmail.com on 20 Aug 2012 at 5:22

GoogleCodeExporter commented 9 years ago
might be more of an issue than that and only evident with this rather than 
normal video, on each seek i think its dispatching a clip event to reattach the 
netstream to it which therefore is dispatching multiple events unneccesarily :)

Original comment by electrot...@gmail.com on 20 Aug 2012 at 5:28

GoogleCodeExporter commented 9 years ago
It's a very embedded issue because of the clip being resized after each start 
event which happens after a seek, these stagevideo events are dispatched also. 
Will look into ways to only call it once only per clip. 

Original comment by electrot...@gmail.com on 21 Aug 2012 at 12:39

GoogleCodeExporter commented 9 years ago

Original comment by electrot...@gmail.com on 21 Aug 2012 at 1:28

GoogleCodeExporter commented 9 years ago
I think I have a solution, I can't go changing the innner internals constantly 
resizing the video unless discusssed, but I can cancel the event once the 
stagevideo mask is positioned, then if we go in and out of fullscreen run the 
event again to reposition.

Original comment by electrot...@gmail.com on 24 Aug 2012 at 8:34

GoogleCodeExporter commented 9 years ago
Please try this

http://dl.dropbox.com/u/3394987/flowplayer.commercial-3.2.14.zip

the logic so far

- If we get a stage video state event and stagevideo is active setup the screen 
mask width / height and position,  unbind the event so no more further action 
happens (clip is being resized on seeks because of the begin event).
- if we get a stage video state event and stage video is not active, remove the 
mask and unbind the event. 
- if we go in and out of fullscreen, listen again for the stage video state 
change event to do the above action and unbind after. 

I think this is clean enough and reduces the amount of calls to this code. The 
issue is because its being called many times unneccesarily, its flickering 
because of the positioning code. 

Original comment by electrot...@gmail.com on 24 Aug 2012 at 9:17

GoogleCodeExporter commented 9 years ago
The video for me still jumps up and down.

Original comment by vil...@lnk.lt on 24 Aug 2012 at 10:57

GoogleCodeExporter commented 9 years ago
Hi I dont see any up and down issue, perhaps this is completely different 
issue. Please post a link ? 

Original comment by electrot...@gmail.com on 24 Aug 2012 at 11:29

GoogleCodeExporter commented 9 years ago
http://post.lnk.lt/flow/

Original comment by vil...@lnk.lt on 24 Aug 2012 at 11:34

GoogleCodeExporter commented 9 years ago
Thanks, I do not see any visual repositioning when seeking in fullscreen here. 
Please provide your OS / browser and how you are controlling the player and ill 
check. 

Original comment by electrot...@gmail.com on 24 Aug 2012 at 12:13

GoogleCodeExporter commented 9 years ago
I'm using Windows XP with Flash 11.3. Tried on IE8, FF14 and Chrome 21. All of 
them behaves the same.

Also probably relevant my screen size is 1920x1200 (more than native 16:9).

Original comment by vil...@lnk.lt on 24 Aug 2012 at 1:05

GoogleCodeExporter commented 9 years ago
Oh, and I'm controlling the player with a mouse. I just left click on the 
controlbar timeline to fast forward a video.

Original comment by vil...@lnk.lt on 24 Aug 2012 at 1:11

GoogleCodeExporter commented 9 years ago
Is it completely repositioning or "flickering" slightly. 

Original comment by electrot...@gmail.com on 24 Aug 2012 at 2:18

GoogleCodeExporter commented 9 years ago
It is repositioning to the top of the screen, and then again goes back to the 
middle.

Original comment by vil...@lnk.lt on 24 Aug 2012 at 2:34

GoogleCodeExporter commented 9 years ago
My vmware windows is showing it its 4:3. it happens after the seek and before 
playback begins hmm. 

Original comment by electrot...@gmail.com on 24 Aug 2012 at 2:37

GoogleCodeExporter commented 9 years ago
Hi im still hacking away at this. There is a ticket in regards to an onbegin 
event being dispatched many times, preventing this prevents the screen being 
resized many times and from what I believe reattaching the stream to the 
stagevideo causes this flicker ! 

Original comment by electrot...@gmail.com on 25 Aug 2012 at 8:39

GoogleCodeExporter commented 9 years ago
It's within the bufferfull event after seeking, I think it's also because it's 
resetting the stage video width / height / x / y directly too. 

Original comment by electrot...@gmail.com on 25 Aug 2012 at 8:45

GoogleCodeExporter commented 9 years ago
Please try this

https://dl.dropbox.com/u/3394987/flowplayer.commercial-3.2.14.zip

The issue is caused by higher up functions. Basically on each buffer full 
notice the display is being removed and added again which triggers a whole 
bunch of events. If we move this to a begin event and with my other fix prevent 
begin being dispatched after seeking it seems to help ;) This might take a 
while to resolve but I think it's close. This is unfortunately evident with 
stagevideo rather than the normal video output because of how it technically 
works it's not part of the display but seperated from flash and gets displayed 
in the gpu card area or something hence why its flashing. 

Original comment by electrot...@gmail.com on 25 Aug 2012 at 9:34

GoogleCodeExporter commented 9 years ago
Works now! Much better and the seeking is a lot faster now, at least it seems.

Original comment by vil...@lnk.lt on 26 Aug 2012 at 12:59

GoogleCodeExporter commented 9 years ago
Do you plan to release 3.2.15 soon or should I use this debug version in 
production?

Original comment by vil...@lnk.lt on 2 Sep 2012 at 2:16

GoogleCodeExporter commented 9 years ago
Confirming as fixed in 3.2.15.

Original comment by vil...@lnk.lt on 10 Sep 2012 at 9:59

GoogleCodeExporter commented 9 years ago
There's still a problem with the Flowplayer branding at the bottom left corner 
during playback. Migrated to https://github.com/flowplayer/flash/issues/20 and 
closing here.

Original comment by blacktrashproduct on 11 Sep 2012 at 8:32