Closed GoogleCodeExporter closed 9 years ago
This issue was updated by revision a2bebdcc1799.
Original comment by justin.forest
on 4 Dec 2011 at 2:30
For some reason there's two H1 elements on the page when I start editing it.
Original comment by justin.forest
on 4 Dec 2011 at 2:30
could you tell me a test pattern ?
Original comment by h.rayflood
on 4 Dec 2011 at 2:55
I can provide a screenshot. I just clicked the "Edit" link and that's what I
see.
I think that's beacause page|wikify_page|safe has its own H1. Perhaps there
needs to be a condition which would not display page.title|escape if there's a
preview.
Original comment by justin.forest
on 4 Dec 2011 at 4:10
Attachments:
exactly.
I think first H1 specifies next block is preview better than simple title.
please review revision 45c244bb310d .
Original comment by h.rayflood
on 4 Dec 2011 at 4:44
Don't you think this could disorient the user?
Example: I click the edit link and see two headers. I think I did something
wrong and delete one and save the page. It has no header now. I'm frustrated.
Original comment by justin.forest
on 4 Dec 2011 at 5:58
I changed to emphasize preview boundary.
How about this ?
Original comment by h.rayflood
on 1 Jan 2012 at 1:28
Attachments:
I think it's OK. There's a way to add custom CSS to customize the look, in
case somebody doesn't like it.
Original comment by justin.forest
on 7 Feb 2012 at 9:43
Original issue reported on code.google.com by
h.rayflood
on 4 Dec 2011 at 1:00Attachments: