google-code-export / galleriffic

Automatically exported from code.google.com/p/galleriffic
0 stars 0 forks source link

onTransitionIn function breaks callback #245

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. include a function in the Galleriffic initilization event "onTransitionIn"

What is the expected output? What do you see instead?
Expected the function to run appropriately and continue the standard 
Galleriffic behavior. Instead, Galleriffic's fade-in is broken and stays at 0 
opacity.

What version of the product are you using? On what operating system?
2.0.1, OSX 10.7.1, Chrome/Saf/FF/O

Please provide any additional information below.

I was able to work around the bug by adding in 
<code>newSlide.fadeTo(this.getDefaultTransitionDuration(isSync), 1.0);</code> 
to the if half of the onTransitionIn function, below 
this.onTransitionIn(blahblah)

Original issue reported on code.google.com by dhutchdr...@gmail.com on 20 Sep 2011 at 10:08

Attachments:

GoogleCodeExporter commented 9 years ago
thanks for that workaround!!

Original comment by eisf...@googlemail.com on 26 Dec 2011 at 2:22

GoogleCodeExporter commented 9 years ago
and i also had to add a fade in for the comments otherwise they would stay at 
zero opacity too: 

if (this.onTransitionIn) {
                    this.onTransitionIn(newSlide, newCaption, isSync);
                     newSlide.fadeTo(this.getDefaultTransitionDuration(isSync), 1.0); //added this line!
                     if (newCaption) newCaption.fadeTo(this.getDefaultTransitionDuration(isSync), 1.0);//and this one for comments
                } else {
                    newSlide.fadeTo(this.getDefaultTransitionDuration(isSync), 1.0);
                    if (newCaption)
                        newCaption.fadeTo(this.getDefaultTransitionDuration(isSync), 1.0);
                }

Original comment by kinv...@gmail.com on 11 Sep 2012 at 10:19