Upgrade worker doesn't save allocation preference/order

[GoogleCodeExporter]

I am not sure if the problem stems from a bug in the back-up/restore saving 
protocol or the upgrade worker itself but...

every time golem is upgraded, the upgrade worker resets to 1 energy regardless 
of what was there before upgrade. I tried forcing a golem back-up but when I 
did restore it returned to the 1 energy instead of what was backed up

Original issue reported on code.google.com by ajsei...@gmail.com on 8 Jan 2011 at 8:00

[GoogleCodeExporter]

Can you confirm that this still happens - I made some internal changes both 
before and after your report, so it might already be fixed as a side-effect of 
these.

I did just find a possible bug in the Backup-All code which didn't exist in the 
individual worker backup, so that has also been fixed.

Original comment by RycochetTM on 9 Jan 2011 at 7:17

• Changed state: Started
• Added labels: Worker-Settings

[GoogleCodeExporter]

Still no good. upgraded to r933, backed up upgrade setting, backed up golem 
setting, restarted and nothing was saved.

Original comment by ajsei...@gmail.com on 9 Jan 2011 at 7:26

[GoogleCodeExporter]

The full settings backup basically backs up every worker - the individual ones 
only deal with the individual workers - but the storage set is the same one.

Which browser are you using?

Original comment by RycochetTM on 9 Jan 2011 at 7:52

[GoogleCodeExporter]

FF. I am aware of what each type of backup does, but decided to do both to 
guarantee at least 1 of them will do the job... which wasn't done 

Original comment by ajsei...@gmail.com on 9 Jan 2011 at 7:54

[GoogleCodeExporter]

Tested in both Firefox and Chrome and I get identical working data -

{
   "order": [
      "Attack",
      "Attack",
      "Defense"
   ],
   "_sleep": true
}

Backup and Restore working as intended... What does your Upgrade.option show?

Original comment by RycochetTM on 9 Jan 2011 at 8:06

[GoogleCodeExporter]

i have:

{
   "order":["Attack"
   ],
   "_sleep":true

after backing up:

attack
energy
energy
stamina

so its clearly not saving my preference

Original comment by ajsei...@gmail.com on 9 Jan 2011 at 8:11

[GoogleCodeExporter]

Actually - if you're going straight to Upgrade.option in Settings, then Backup 
won't affect it in the slightest...

As you're in Firefox, can you go to about:config, filter down to Upgrade and 
see what it shows.

It does sound like something else is interfering with the data - maybe an addon 
that preserves your settings, or an older (or newer?) version of 
Greasemonkey...?

I've been through the code with a fine comb, and can't find any other possible 
bugs in there, so it really is a case of tracking it down now...

Original comment by RycochetTM on 9 Jan 2011 at 8:23

[GoogleCodeExporter]

Greasemonkey v0.8.20100408.6
about:config shows same as upgrade.option in settings 
{"order":["Attack"],"_sleep":true}

could this be connected to the problems Im having with the dash incl. 
permanently showing a non-existent stam potion (as I brought up in issue 2330)?

Original comment by ajsei...@gmail.com on 9 Jan 2011 at 8:36

[GoogleCodeExporter]

This may have been related to the core bug I fixed in r943 - is it still 
happening?

Original comment by RycochetTM on 10 Jan 2011 at 9:56

[GoogleCodeExporter]

r944 still broken

Original comment by ajsei...@gmail.com on 10 Jan 2011 at 5:14

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

r954 same problem.
Set upgrade, close/restart FF, upgrades unset.
But in my case it's a blank box for the upgrades.
I'm only setting one Attack

Original comment by vitae...@gmail.com on 11 Jan 2011 at 10:10

[GoogleCodeExporter]

Ok, so after trying this 10 (YES 10 just to make sure it's not a Vitaeism) 
times, it finally saved.
I left the Upgrade worker open, and left Upgrade.Option open in the Setting, 
closed/opened FF.
BUT it had 2 Attacks set, where I only had one.
Deleted one.
Closed/reopen FF
Still have 2.
try a few more times, doing the same steps I said above, still 2...

Original comment by vitae...@gmail.com on 11 Jan 2011 at 10:16

[GoogleCodeExporter]

"could this be connected to the problems Im having with the dash incl. 
permanently showing a non-existent stam potion (as I brought up in issue 2330)?"

Swear, almost sounds like my exact issue from before...

If I didn't know any better i'd think you were me...

Original comment by vitae...@gmail.com on 12 Jan 2011 at 1:30

[GoogleCodeExporter]

Upgrade has been totally rewritten, so any further issues are unrelated.

Original comment by RycochetTM on 4 Jun 2011 at 9:06

• Changed state: Fixed