Generals change bug

[GoogleCodeExporter]

Here again with moar bugs in Generals worker.

Some generals type (checked the source code of the page) is 0

---------------------------------
<form .... etc etc etc>                 
                    <input type="hidden" name="item" value="16">
---->                   <input type="hidden" name="itype" value="0">
                    <input class="imgButton" type="image" name="Select" alt="Select" width="110" height="110" src="http://image4.castleagegame.com/2942/graphics/hero_aeris.jpg">
                    <input type="hidden" name="ajax" value="1">
                    </form>
----------------------------------

And this expression I mark makes the Page.to try to put a "null" General.

----------------------------------
    if (!this.test(name)) {
        console.log(log('General rejected due to energy or stamina loss: ' + Player.get('general') + ' to ' + name));
        return true;
    }
    console.log(warn('General change: ' + Player.get('general') + ' to ' + name));
--->Page.to('heroes_generals', this.data[name].id && this.data[name].type ? 
{item:this.data[name].id, itype:this.data[name].type} : null, true);
    return false;
};
----------------------------------

Another hopefully easy to fix bug ;)

Sorry i can't provide a fix, i can read the language (all are about the same), 
i can find bugs but i don't know enough javascript to write a fix. Hopefully i 
make them easier to fix ;)

Original issue reported on code.google.com by anarel...@gmail.com on 2 Apr 2011 at 9:01

[GoogleCodeExporter]

Was fixed back in 1046 - remember to update before submitting a bug report ;-)

Original comment by RycochetTM on 2 Apr 2011 at 9:32

• Changed state: Fixed
• Added labels: Worker-CA-Generals

[GoogleCodeExporter]

Aw... that hurt me :) sorry, didnt see new issues and posted happyly. Wont 
happen again.

Original comment by anarel...@gmail.com on 2 Apr 2011 at 9:35

[GoogleCodeExporter]

Been pushing out a lot of bugfixes and rewrites today - not surprised you 
missed that one lol

Original comment by RycochetTM on 2 Apr 2011 at 9:37