google-code-export / game-golem

Automatically exported from code.google.com/p/game-golem
0 stars 0 forks source link

Page.page not set after button clicks #317

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Do an action twice that goes to a page, and then clicks a button like 
drinking 2 potions or attacking someone in battle.
2. Watch the page click the button, and then reload the page, even though it's 
on the same page, and could immediately click the button again.

What is the expected output? What do you see instead?
After drinking the first potion, since it is still on the keep page, it should 
drink the second potion from that page, instead of reloading the keep.

Please use labels and text to provide additional information.
Seems to be an issue with the Page.update not running after a button click, so 
the page is unknown.

Original issue reported on code.google.com by 0Artifi...@gmail.com on 5 May 2011 at 7:39

GoogleCodeExporter commented 9 years ago
Some button actions don't trigger a full page reload - was talking with lurgid 
last night about this but can't see how to deal with it right this second.

Original comment by RycochetTM on 5 May 2011 at 1:06

GoogleCodeExporter commented 9 years ago
Just looking / thinking about this a bit more - some pages have multiple 
versions, ie. Keep has your own, and other people's. We currently have very 
basic (but getting better) identification for pages in there - but it needs to 
get better.

Lurgid has some code that will hopefully get into trunk soon which gives more 
efficient handling, but that still doesn't help the "force go to Keep to make 
sure it's our own" issue... Basically - Page identification of exactly which 
version of a page we're in needs improvement so we never need to force a page 
load, and Page itself can automatically handle when you ask to go to the same 
page and there's a high chance of it being stale.

Waiting for Lurgid's code before doing anything else with this, as that handles 
the majority of it I believe ;-)

Currently it just wastes page loads, but gets the job done, so changing to an 
enhancement.

Original comment by RycochetTM on 11 May 2011 at 10:44