Closed GoogleCodeExporter closed 9 years ago
Cutting release at 901:0fd6b23a0217
Original comment by vicfry...@google.com
on 8 Nov 2010 at 7:11
Ran unit tests at the specified revision, and got some errors. Fixing those
prior to proceeding with this release.
................................................................................
....................F...........................................................
........................................E...................E...................
............analytics#profiles
.........E.............E............................................
======================================================================
ERROR: test_create_update_delete_table_and_records
(gdata_tests.spreadsheets.live_client_test.SpreadsheetsClientTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/vicfryzel/workspace/gdata-python-client/tests/gdata_tests/spreadsheets/live_client_test.py", line 103, in test_create_update_delete_table_and_records
column_headers={'B': 'Food', 'C': 'Drink', 'A': 'Price'})
File "/home/vicfryzel/workspace/gdata-python-client/src/gdata/spreadsheets/client.py", line 207, in add_table
auth_token=auth_token, **kwargs)
File "/home/vicfryzel/workspace/gdata-python-client/src/gdata/client.py", line 685, in post
desired_class=desired_class, **kwargs)
File "/home/vicfryzel/workspace/gdata-python-client/src/gdata/client.py", line 320, in request
RequestError)
RequestError: Server responded with: 403, This operation is not permitted
because it would alter the structure of this table. <a target=_blank
href=http://docs.google.com/support/bin/answer.py?answer=156100&hl=en_US>More
information</a>
======================================================================
ERROR: testCreateAndUploadToFilecabinet
(gdata_tests.sites.live_client_test.SitesClientTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/vicfryzel/workspace/gdata-python-client/tests/gdata_tests/sites/live_client_test.py", line 98, in testCreateAndUploadToFilecabinet
description='description here')
File "/home/vicfryzel/workspace/gdata-python-client/src/gdata/sites/client.py", line 412, in upload_attachment
content_type=content_type)
File "/home/vicfryzel/workspace/gdata-python-client/src/gdata/data.py", line 1163, in __init__
self.set_file_handle(file_path, content_type)
File "/home/vicfryzel/workspace/gdata-python-client/src/gdata/data.py", line 1174, in set_file_handle
self.file_handle = open(file_name, 'rb')
IOError: [Errno 2] No such file or directory: '../uploadme.png'
======================================================================
ERROR: Tests if the Data Feed exists.
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/vicfryzel/workspace/gdata-python-client/tests/gdata_tests/analytics/live_client_test.py", line 104, in testDataFeed
self.assertEquals(feed.entry[0].GetMetric(metrics).name, metrics)
IndexError: list index out of range
======================================================================
ERROR: testUpdateForwarding
(gdata_tests.apps.emailsettings.live_client_test.EmailSettingsClientTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/vicfryzel/workspace/gdata-python-client/tests/gdata_tests/apps/emailsettings/live_client_test.py", line 185, in testUpdateForwarding
action='KEEP')
File "/home/vicfryzel/workspace/gdata-python-client/src/gdata/apps/emailsettings/client.py", line 253, in update_forwarding
return self.update(new_forwarding, **kwargs)
File "/home/vicfryzel/workspace/gdata-python-client/src/gdata/client.py", line 720, in update
desired_class=entry.__class__, **kwargs)
File "/home/vicfryzel/workspace/gdata-python-client/src/gdata/client.py", line 320, in request
RequestError)
RequestError: Server responded with: 500, <?xml version="1.0" encoding="UTF-8"?>
<AppsForYourDomainErrors>
<error errorCode="1000" invalidInput="" reason="UnknownError" />
</AppsForYourDomainErrors>
======================================================================
FAIL: test_query_modifies_request (gdata_tests.client_test.QueryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/vicfryzel/workspace/gdata-python-client/tests/gdata_tests/client_test.py", line 318, in test_query_modifies_request
self.assertEqual(request.uri.query, {'q': 'foo', 'categories': 'a,b'})
AssertionError: {'q': 'foo', 'category': 'a,b'} != {'q': 'foo', 'categories':
'a,b'}
----------------------------------------------------------------------
Original comment by vicfry...@google.com
on 8 Nov 2010 at 7:42
If possible, could the release be delayed until this patch is reviewed and
submitted?
http://codereview.appspot.com/2945041/
That, along with http://codereview.appspot.com/2915041/, fixes Issue 414.
Original comment by tom.h.mi...@gmail.com
on 9 Nov 2010 at 5:23
Hey Tom,
Sure, sorry I missed that there were two patches for that issue. I'll re-cut
the release after that patch is reviewed. This works out anyway because there
were some test failures I need to work out.
Thanks,
Vic
Original comment by vicfry...@google.com
on 9 Nov 2010 at 6:04
Tom,
I want to wait for Joe to review that change you've sent. Once it's submitted
we'll cut another release. I'm going to continue 2.0.13 without it, but
cutting a new release isn't a big deal.
Thanks,
Vic
Original comment by vicfry...@google.com
on 16 Nov 2010 at 10:01
Given the failing tests and all that, I'm re-cutting 2.0.13 at 902:73f3fbb5ea88.
Original comment by vicfry...@google.com
on 16 Nov 2010 at 10:02
Tests are now passing, with the exception of two sites tests, which are
expected failures.
Original comment by vicfry...@google.com
on 16 Nov 2010 at 10:03
Forgot to mark this as fixed, release is live.
Original comment by vicfry...@google.com
on 3 Dec 2010 at 2:29
Original issue reported on code.google.com by
vicfry...@google.com
on 8 Nov 2010 at 7:10